From 3f7218d657ee9d100c6eb009e46d1a74c09d026b Mon Sep 17 00:00:00 2001 From: "Addisu Z. Taddese" Date: Mon, 5 Dec 2022 10:40:21 -0600 Subject: [PATCH] Fix QML warnings regarding binding loops (#1829) In aboutDialog (line 178), the binding loop was created because the height of aboutDialog wasn't set. It was dependent on the height of its child (aboutMessage). But aboutMessage had anchor.fill : parent set which binds its height to the height of its parent. Similar reasoning applies to fileSaveFailure. Signed-off-by: Addisu Z. Taddese --- src/gui/resources/GazeboDrawer.qml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gui/resources/GazeboDrawer.qml b/src/gui/resources/GazeboDrawer.qml index 647883da34..3614244dad 100644 --- a/src/gui/resources/GazeboDrawer.qml +++ b/src/gui/resources/GazeboDrawer.qml @@ -183,6 +183,7 @@ Rectangle { focus: true parent: ApplicationWindow.overlay width: parent.width / 3 > 500 ? 500 : parent.width / 3 + height: 300 x: (parent.width - width) / 2 y: (parent.height - height) / 2 closePolicy: Popup.CloseOnEscape @@ -292,6 +293,7 @@ Rectangle { modal: true focus: true parent: ApplicationWindow.overlay + width: messageText.implicitWidth x: (parent.width - width) / 2 y: (parent.height - height) / 2 closePolicy: Popup.CloseOnEscape