Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress "missing Optix" cmake warning #281

Open
chapulina opened this issue Mar 25, 2021 · 3 comments
Open

Suppress "missing Optix" cmake warning #281

chapulina opened this issue Mar 25, 2021 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@chapulina
Copy link
Contributor

Environment

  • OS Version: Ubuntu
  • Source or binary build?
    either

Description

  • Expected behavior: Our CI should be green, warning-free. But since Fix cmake message types gz-cmake#159 we get warnings for missing dependencies. Since Optix is optional and we don't plan on running CI for it, I think we should disable these warnings.

  • Actual behavior: There are CMake warnings

Steps to reproduce

Build ign-rendering without Optix installed.

Output

-- Cannot build component [optix] - Missing: OptiX

@chapulina chapulina added the bug Something isn't working label Mar 25, 2021
@j-rivero
Copy link
Contributor

Quick look at it, if I'm not wrong the logic goes:

If that is correct, we probably want to add an option to ign_find_package that can indicate that missing support is not a warning.

@chapulina
Copy link
Contributor Author

option to ign_find_package that can indicate that missing support is not a warning

I'd expect that calling find_package with QUIET wouldn't print a warning, so maybe we can do the same for ign_find_package?

@chapulina
Copy link
Contributor Author

chapulina commented Apr 23, 2021

@j-rivero , I have a suggestion on the PRs above ☝️


https://github.com/osrf/buildfarmer/issues/181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants