Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add link offset to tpeplugin::KinematicsFeatures #57

Closed
claireyywang opened this issue May 28, 2020 · 0 comments · Fixed by #83
Closed

Add link offset to tpeplugin::KinematicsFeatures #57

claireyywang opened this issue May 28, 2020 · 0 comments · Fixed by #83
Assignees
@claireyywang
Labels
enhancement New feature or request TPE Trivial Physics Engine

Comments

@claireyywang
Copy link
Contributor

Current implementation does not consider link position. Setting model pos also sets every entity within the model. We will need to consider the offset when there is a tag in , and adjust framedata accordingly. More info refer to discussion here #46 (comment)
@claireyywang claireyywang added the enhancement New feature or request label May 28, 2020
@claireyywang claireyywang mentioned this issue May 28, 2020
Merged
@chapulina chapulina added the TPE Trivial Physics Engine label May 30, 2020
@chapulina chapulina mentioned this issue Jun 12, 2020
Merged
@claireyywang claireyywang self-assigned this Jun 17, 2020
This was referenced Jul 9, 2020
Merged
Merged
@claireyywang claireyywang linked a pull request Jul 15, 2020 that will close this issue
Add link offset to simulation #83
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@claireyywang claireyywang

Labels
enhancement New feature or request TPE Trivial Physics Engine
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add link offset to simulation gazebosim/gz-physics
2 participants
@chapulina @claireyywang