Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial links to line-numbers are out of date #199

Closed
scpeters opened this issue Jan 16, 2021 · 2 comments · Fixed by #259
Closed

Tutorial links to line-numbers are out of date #199

scpeters opened this issue Jan 16, 2021 · 2 comments · Fixed by #259
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed

Comments

@scpeters
Copy link
Member

Some links to lines of code in a tutorial are out of date (see https://github.com/ignitionrobotics/ign-physics/pull/191/files#r557676961). They are pointing to branches rather than specific commits, and the line numbers are no longer accurate.

Also, there is a reference to master in that same paragraph that should be updated to main.

@scpeters scpeters added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Jan 16, 2021
@chapulina chapulina added the good first issue Good for newcomers label Jan 20, 2021
@Ambuj-Pandey
Copy link

i am new to open source and want to contribute also want to work on this my very first issue . Can you please guide me ??

@ahcorde
Copy link
Contributor

ahcorde commented Feb 8, 2021

Hi @Ambuj-Pandey,

My recommendations:

Then select an issue (like this one, tagged as "good first issue") and start contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants