🧑‍🌾 CmdLine test regressions in gz-launch2-homebrew

[Crola1702]

Environment

• OS Version: MacOS Monterey and Ventura
• Binary build - Citadel

Description

• Expected behavior: Tests should pass
• Actual behavior: CmdLine Tests are failing

Steps to reproduce

1. Run a build in ign-launch2
2. See 2 test regressions

Output

Reference build: https://build.osrfoundation.org/job/ignition_launch-ci-ign-launch2-homebrew-amd64/59/

Failing tests:

• CmdLine.Ls
• CmdLine.EchoSelf

Log output:

The following tests FAILED:
	  3 - UNIT_ign_TEST (Failed)

Test 3 - UNIT_ign_TEST output:

test 3
    Start 3: UNIT_ign_TEST

3: Test command: /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/build/bin/UNIT_ign_TEST "--gtest_output=xml:/Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/build/test_results/UNIT_ign_TEST.xml"
3: Working Directory: /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/build/src
3: Test timeout computed to be: 240
3: Running main() from /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/ign-launch/test/gtest/src/gtest_main.cc
3: [==========] Running 3 tests from 1 test suite.
3: [----------] Global test environment set-up.
3: [----------] 3 tests from CmdLine
3: [ RUN      ] CmdLine.Ls
3: Running command [IGN_CONFIG_PATH=/Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/build/test/conf /usr/local/opt/ruby/bin/ruby /usr/local/bin/ign launch /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/ign-launch/test/config/ls.ign]
3: Library error: Problem running [launch]() from /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/build/lib/libignition-launch2.2.3.0.dylib.
3: 
3: /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/ign-launch/src/ign_TEST.cc:63: Failure
3: Value of: output.find("CMakeFiles") != std::string::npos
3:   Actual: false
3: Expected: true
3: Library error: Problem running [launch]() from /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/build/lib/libignition-launch2.2.3.0.dylib.
3: 
3: /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/ign-launch/src/ign_TEST.cc:64: Failure
3: Value of: output.find("Makefile") != std::string::npos
3:   Actual: false
3: Expected: true
3: Library error: Problem running [launch]() from /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/build/lib/libignition-launch2.2.3.0.dylib.
3: 
3: [  FAILED  ] CmdLine.Ls (913 ms)
3: [ RUN      ] CmdLine.EchoSelf
3: /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/ign-launch/src/ign_TEST.cc:76: Failure
3: Expected equality of these values:
3:   filePath
3:     Which is: "/Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/ign-launch/test/config/echo.ign"
3:   output
3:     Which is: "Library error: Problem running [launch]() from /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/build/lib/libignition-launch2.2.3.0.dylib.\n"
3: Library error: Problem running [launch]() from /Users/jenkins/workspace/ignition_launch-ci-ign-launch2-homebrew-amd64/build/lib/libignition-launch2.2.3.0.dylib.
3: 
3: [  FAILED  ] CmdLine.EchoSelf (211 ms)
3: [ RUN      ] CmdLine.HelpVsCompletionFlags
3: [       OK ] CmdLine.HelpVsCompletionFlags (212 ms)
3: [----------] 3 tests from CmdLine (1336 ms total)
3: 
3: [----------] Global test environment tear-down
3: [==========] 3 tests from 1 test suite ran. (1336 ms total)
3: [  PASSED  ] 1 test.
3: [  FAILED  ] 2 tests, listed below:
3: [  FAILED  ] CmdLine.Ls
3: [  FAILED  ] CmdLine.EchoSelf
3: 
3:  2 FAILED TESTS
3/6 Test #3: UNIT_ign_TEST ......................***Failed    1.41 sec

Gz-sim7 and ign-gazebo3 have similar issues reported here: gazebosim/gz-sim#1867

[Crola1702]

This issue is still happening in homebrew both monterey and ventura OS versions.

Reference build: https://build.osrfoundation.org/job/gz_launch-ci-ign-launch2-homebrew-amd64/35/#showFailuresLink

Log output is similar:

/Users/jenkins/jenkins-agent/workspace/gz_launch-ci-ign-launch2-homebrew-amd64/gz-launch/src/ign_TEST.cc:63
Value of: output.find("CMakeFiles") != std::string::npos
  Actual: false
Expected: true
Library error: Problem running [launch]() from /Users/jenkins/jenkins-agent/workspace/gz_launch-ci-ign-launch2-homebrew-amd64/build/lib/libignition-launch2.2.3.1.dylib.

[scpeters]

there was a big change between gz-launch2 and gz-launch5 in #121

backporting that change (if possible) may resolve this?

[Crola1702]

Closing as this problem hasn't happened since 2024-05-27.