Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

finding package with components that have a dependent relationship is tricky #48

Closed
1 task done
osrf-migration opened this issue Dec 19, 2018 · 3 comments
Closed
1 task done
Labels
bug Something isn't working major

Comments

@osrf-migration
Copy link

Original report (archived issue) by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


Prerequisites

  • Put an X between the brackets on this line if you have done all of the following:

Description

If a package has components with a dependency relationship (such as ign-physics-dartsim-plugin, which depends on ignition-physics-sdf and ignition-physics-mesh), then then all the components must be listed in the ign_find_package call and in a proper order. The following is a workaround for this issue in ign-gazebo:

Steps to Reproduce

I've demonstrated this issue with some examples committed to branch find_component_order_working and branch find_component_order. The find_component_order_working branch creates a package component_deps that has two components: parent and child, and the child component links against the parent. There is a second package called use_component_deps1 that makes an ign_find_package call for component_deps specifying both components parent child. This example builds fine:

  1. hg up find_component_order_working
  2. mkdir build && cd build && cmake ..
  3. make (successful)

Now on branch branch find_component_order, another example named use_component_deps2 is added that differs from use_component_deps1 only in the order that components are specified in the ign_find_package call, but it fails to build:

  1. hg up find_component_order
  2. mkdir build && cd build && cmake ..
  3. make (unsuccessful)

Expected behavior:

I would expect the examples to build regardless of the order in which components are specified. Furthermore, I would that specifying a component would cause dependent components to be included as well (as in the ign-physics example mentioned above).

Actual behavior:

ign_find_package is sensitive to the order of specified components when there is a dependent relationship, and dependent components must all be listed.

Reproduces how often:

100%

Versions

ign-cmake1 and ign-cmake2

Additional Information

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


  • Edited issue description

@osrf-migration
Copy link
Author

Original comment by Michael Grey (Bitbucket: mxgrey, GitHub: mxgrey).


Pull request #131 should fix this now.

@osrf-migration
Copy link
Author

Original comment by Steve Peters (Bitbucket: Steven Peters, GitHub: scpeters).


  • changed state from "new" to "resolved"

pull request #131

@osrf-migration osrf-migration added major bug Something isn't working labels Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working major
Projects
None yet
Development

No branches or pull requests

1 participant