-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing page should show a 404, not a blank page with an Edit icon? #29
Comments
I think that the page you're trying to edit should show a 404 instead of a title and pencil: https://ignitionrobotics.org/docs/releases This is the correct page and its edit button redirects to the correct GitHub file for me: https://ignitionrobotics.org/docs/all/releases ⬇️ https://github.com/ignitionrobotics/docs/blob/master/releases.md |
Huh... now that you mention it, I have no idea how I came across the wrong link https://ignitionrobotics.org/docs/releases - I don't think I typed it in, but in Firefox History, I can't seem to identify what my sites were referrers were at the time of the visit... So yup, that sounds good! Want me to re-purpose this issue, or close it and open a more accurate one? |
I'm fine either way, thanks! |
Repurposed! |
@nkoenig I fixed this on the backend. Do you mind to have a look? |
Fix has been merged but not deployed |
Spoke too soon, this pattern is still broken: https://ignitionrobotics.org/docs/latest/banana CC @ahcorde |
This PR fixed
https://gitlab.com/ignitionrobotics/web/web/-/merge_requests/20 |
Thanks, I think we're all set now. |
Update: From @chapulina
As I was investigating #28, I tried clicking on the Edit Icon (
), and it took me to the following link which is broken:
https://github.com/ignitionrobotics/docs/blob/master/
I think the correct link should have been either:
https://github.com/ignitionrobotics/docs/blob/master/releases.md
or
https://github.com/ignitionrobotics/docs/tree/master/ ?
Current commit: 198e1f9
The text was updated successfully, but these errors were encountered: