Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing page should show a 404, not a blank page with an Edit icon? #29

Closed
EricCousineau-TRI opened this issue May 30, 2020 · 10 comments
Closed
Assignees
Labels
infrastructure Requires changes on the web server or other infra

Comments

@EricCousineau-TRI
Copy link

EricCousineau-TRI commented May 30, 2020

Update: From @chapulina

I think that the page you're trying to edit should show a 404 instead of a title and pencil:


As I was investigating #28, I tried clicking on the Edit Icon (), and it took me to the following link which is broken:
https://github.com/ignitionrobotics/docs/blob/master/

I think the correct link should have been either:
https://github.com/ignitionrobotics/docs/blob/master/releases.md
or
https://github.com/ignitionrobotics/docs/tree/master/ ?

Current commit: 198e1f9

@chapulina
Copy link
Contributor

I think that the page you're trying to edit should show a 404 instead of a title and pencil:

https://ignitionrobotics.org/docs/releases

This is the correct page and its edit button redirects to the correct GitHub file for me:

https://ignitionrobotics.org/docs/all/releases

⬇️

https://github.com/ignitionrobotics/docs/blob/master/releases.md

@EricCousineau-TRI
Copy link
Author

Huh... now that you mention it, I have no idea how I came across the wrong link https://ignitionrobotics.org/docs/releases - I don't think I typed it in, but in Firefox History, I can't seem to identify what my sites were referrers were at the time of the visit...

So yup, that sounds good! Want me to re-purpose this issue, or close it and open a more accurate one?

@chapulina
Copy link
Contributor

Want me to re-purpose this issue, or close it and open a more accurate one?

I'm fine either way, thanks!

@EricCousineau-TRI EricCousineau-TRI changed the title "Edit" button redirects to wrong link? Missing page should show a 404, not a blank page with an Edit icon? Jun 2, 2020
@EricCousineau-TRI
Copy link
Author

Repurposed!

@chapulina chapulina added the infrastructure Requires changes on the web server or other infra label Jun 5, 2020
@ahcorde ahcorde self-assigned this Aug 18, 2020
@ahcorde
Copy link
Contributor

ahcorde commented Aug 18, 2020

@nkoenig I fixed this on the backend. Do you mind to have a look?

@scpeters
Copy link
Member

Fix has been merged but not deployed

@chapulina
Copy link
Contributor

@chapulina
Copy link
Contributor

Spoke too soon, this pattern is still broken: https://ignitionrobotics.org/docs/latest/banana

CC @ahcorde

@chapulina chapulina reopened this Aug 27, 2020
@ahcorde
Copy link
Contributor

ahcorde commented Aug 28, 2020

This PR fixed

  • /docs/<wrong_release>/install
  • /docs/citadel/< wrong tutorial >

https://gitlab.com/ignitionrobotics/web/web/-/merge_requests/20

@chapulina
Copy link
Contributor

Thanks, I think we're all set now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Requires changes on the web server or other infra
Projects
None yet
Development

No branches or pull requests

5 participants