Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[www] Open search form with keyboard shortcut #3602

Closed
m-allanson opened this issue Jan 19, 2018 · 5 comments
Closed

[www] Open search form with keyboard shortcut #3602

m-allanson opened this issue Jan 19, 2018 · 5 comments

Comments

@m-allanson
Copy link
Contributor

Add keyboard shortcut / to open the search form on gatsbyjs.org.

Ref: #3421 (comment)

@markmichon
Copy link
Contributor

Is this convention? Some browsers default / to Find. (like Firefox)

Currently, it's the first tab target, which generally a good a11y practice.

@KyleAMathews
Copy link
Contributor

Oh hmmm good point. I've done it on a web app before and it was great but perhaps it's not worth doing it here.

@m-allanson
Copy link
Contributor Author

Maybe we could look at how GitHub handles it? On the issues page / opens Firefox's built in 'Find in page' control, but for other browsers it focusses the issue search box.

@m-allanson
Copy link
Contributor Author

We could also use a key that doesn't conflict with any existing browser shortcuts. Check out the full range of GitHub shortcuts with ?.

@KyleAMathews
Copy link
Contributor

Yeah, they use s which seems reasonable. We could also use copy their "go to" commands e.g. gd is go to docs, gp is go to package search page (once that's built that is :-)). Which would be fun too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants