excerpt needs to fall back to pruneLength when no excerpt_separator

[fabianrios]

Summary

excerpt falling back to pruneLength when there is no custom excerpt_separator on the file

Basic example

config.js

{
      resolve: `gatsby-transformer-remark`,
      options: {
        "excerpt_separator": `<!-- endexcerpt -->`
      }
    },

template.js

node {
          id
          excerpt(pruneLength: 140, format: MARKDOWN)
}

Motivation

I had to put a custom excerpt for just 2 files and the rest will look just fine with the default 140 pruneLength but it turns out it doesn't fall back so I have to manually edit hundreds of files to add a which wouldn´t have been necessary if the excerpt function just fall back to pruneLength when there is no in the file.

EDIT: Reproduction example here: samrae7/gatsby-remark-repro

[samrae7]

I would like to take this. Will work on it this weekend and post here if I get blocked.

[samrae7]

@fabianrios do your markdown files contain html or just plain markdown? Can you post an example of the formatting you have? Trying to reproduce this issue.

[samrae7]

@fabianrios ignore previous question. I have replicated the behaviour with markdown: https://github.com/samrae7/gatsby-remark-repro

[samrae7]

still working on this. PR coming in next couple of days

[fabianrios]

happy to see action was taken, I lost track of this for a while.

[github-actions]

Hiya!

This issue has gone quiet. Spooky quiet. 👻

We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here.
If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!
As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing!

Thanks for being a part of the Gatsby community! 💪💜

[samrae7]

Awaiting reviewing response from @pieh

[samrae7]

@fabianrios can you review the PR as well?