-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IE10 - 'Set' is undefined #13166
Comments
@MariuszDabrowski let me start by saying i'm sorry for the issue you're having, but some tangible issues regarding this type of situation keep being created in here. import 'core-js/modules/es6.set';
import 'core-js/modules/es6.map'; Be advised that using Gatsby with ie10 in development mode there are some issues regarding hmr (hot module replacement). But for production build adding those imports should resolve your issue. A little more context on the issue in here Feel free to provide feedback |
@jonniebigodes thank you for the prompt reply. Still working with Gatsby default starter without any modifications besides adding the code below to
After building the project and running a local server on the |
@MariuszDabrowski i've been trying to see if i could see what is the problem you're experiencing and i wasn't able to reproduce it. Now i tested it out with a production build and Gatsby's internal server through Going back and forward always produced the same result, no errors. I took it a step further, deployed to netlify and applied the same test as above and the results are as you can see below: To cover my basis, i've added a dummy express server with the following code: const express= require('express');
const app= express()
app.use(express.static('public'))
app.set('port', process.env.PORT || 5000)
app.get('*', (req, res) => {
res.sendFile('./public/index.html')
})
app.listen(app.get('port'),error=>{
if (error){
console.log('====================================');
console.error(`error starting server with error:\n${error}`);
console.log('====================================');
}
else{
console.log('====================================');
console.info(`dummy express server running @ ${app.get('port')}`)
console.log('====================================');
}
}) Added the production build to it. Issued Now after all of this, it led me to two things. One, what kind of server you're using and how you're running it and two, as i have only access to a trial version of browserstack and with that the number of testing options at my disposal are really very limited i'm not sure if the problem is actually with browserstack and how it emulates the os/browser and the versions they emulate, namely to what point in time |
@jonniebigodes thank you for the thorough response. I have to admit that I'm not an expert when it comes to the server portion of web apps, but here's what we figured out:
So it looks like the error was happening because the other ways I tried to serve the site weren't redirecting to Thanks again for the help! |
@MariuszDabrowski i factored in what you said and expanded my tests.
On the left is the configuration for the site, on the right the contents of the folder with the Gatsby production build files. Starting nginx and applying the same tests like before yelded the same results as i mentioned abvode.
As i'm not aware of the setup you used probably was something related to what you said. It was probably a misconfiguration on the server part. Also no need to thank, glad that i could help out in at least point you in the right direction for solving your issue. |
Sadly we don't include polyfills for react. {
resolve: `gatsby-plugin-compile-es6-packages`,
options: {
modules: [`react-dom`]
}
} We have an issue open to actually look into this |
Hiya! This issue has gone quiet. Spooky quiet. 👻 We get a lot of issues, so we currently close issues after 30 days of inactivity. It’s been at least 20 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open! As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contributefor more information about opening PRs, triaging issues, and contributing! Thanks for being a part of the Gatsby community! 💪💜 |
Hey again! It’s been 30 days since anything happened on this issue, so our friendly neighborhood robot (that’s me!) is going to close it. Please keep in mind that I’m only a robot, so if I’ve closed this issue in error, I’m As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request. Check out gatsby.dev/contribute for more information about opening PRs, triaging issues, and contributing! Thanks again for being part of the Gatsby community! |
Description
Using the Gatsby default starter, if you build the project and preview the built project in IE10 you get the following error:
SCRIPT5009: 'Set' is undefined
Steps to reproduce
npm run build
Environment
Browser testing was done in Browser stack - Win 7 IE 10
The text was updated successfully, but these errors were encountered: