Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gatsby] headComponents can be empty (null or empty array) values #12553

Closed
danielkov opened this issue Mar 13, 2019 · 1 comment
Closed

[gatsby] headComponents can be empty (null or empty array) values #12553

danielkov opened this issue Mar 13, 2019 · 1 comment

Comments

@danielkov
Copy link
Contributor

Description

This is related to #12549 and as discussed in the comments, sanitizing headComponents would ensure that plugins that do similar transformations as the one in that issue can assume that all elements are actual components.

Steps to reproduce

As of now it is possible to call setHeadComponents or replaceHeadComponents with any values and there are no sanity checks in place.

Expected result

Empty values (null, empty array) should be filtered out.

Actual result

Everything gets added.

Environment

Not environment specific.
@danielkov danielkov mentioned this issue Mar 13, 2019
Merged
@sidharthachatterjee
Copy link
Contributor

Thank you for opening this and the pull request @danielkov 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sidharthachatterjee @danielkov