Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove go tool cover usage from inside .ci/test-unit #88

Closed
unmarshall opened this issue May 24, 2023 · 0 comments · Fixed by #89
Closed

Remove go tool cover usage from inside .ci/test-unit #88

unmarshall opened this issue May 24, 2023 · 0 comments · Fixed by #89
Labels
area/control-plane Control plane related area/dev-productivity Developer productivity related (how to improve development) kind/bug Bug kind/cleanup Something that is not needed anymore and can be cleaned up priority/3 Priority (lower number equals higher priority)

Comments

@unmarshall
Copy link
Contributor

unmarshall commented May 24, 2023 •
edited
Loading

How to categorize this issue?

/area control-plane
/area dev-productivity
/kind cleanup
/priority 3

What happened:
go tool cover is defined in .ci/test-unit where as the actual test run inside hack/test.sh. The hack/test.sh has been changed and it does no longer create a coverage report as the tests are divided into 3 sets and run sequentially one after the other. Reason is kubernetes-sigs/controller-runtime#1363

What you expected to happen:
Remove call to go tool cover from .ci/test-unit
@unmarshall unmarshall added the kind/bug Bug label May 24, 2023
@gardener-prow gardener-prow bot added area/control-plane Control plane related area/dev-productivity Developer productivity related (how to improve development) kind/cleanup Something that is not needed anymore and can be cleaned up priority/3 Priority (lower number equals higher priority) labels May 24, 2023
@unmarshall unmarshall changed the title Move go tool cover usage inside hack/test.sh Remove go tool cover usage from inside .ci/test-unit May 24, 2023
@unmarshall unmarshall mentioned this issue May 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/control-plane Control plane related area/dev-productivity Developer productivity related (how to improve development) kind/bug Bug kind/cleanup Something that is not needed anymore and can be cleaned up priority/3 Priority (lower number equals higher priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed the call to go tool cover unmarshall/dependency-watchdog
1 participant
@unmarshall