Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ARIA support to Mobile Menu/Offcanvas toggle for improved accessibility #1891

Closed
N8Solutions opened this issue Feb 25, 2017 · 3 comments
Closed
Assignees
Milestone

Comments

@N8Solutions
Copy link

In reviewing Gantry 5 for accessibility enhancements I noticed the Mobile Menu / Offcanvas Toggle has no ARIA attributes associated with it.

I do not believe aria-hidden should be added to the icon since it is an Interactive Element nor should it only be recognized as a menu because it can also be set to be visible on tablets and larger screens that may not contain menu items.

I would suggest the ARIA support be added in a way so that it recognizes the Toggle as the Menu when the screen size is that of a mobile and something like Expand Offcanvas.

I found this issue on GitHub from Automattic and how they addressed the issue of accessibility with the Toggle.
Automattic/_s#545

@mahagr
Copy link
Member

mahagr commented Apr 26, 2017

Automattic/_s@e142af3

Great idea. I'm assigning this to @w00fz as there's javascript change which needs to be done.

@mahagr
Copy link
Member

mahagr commented Jun 1, 2017

By default the particle div should have: aria-controls="menu" aria-expanded="false". When mobile menu gets shown, javascript should change aria-expanded="true" and back to false depending on the state of the menu.

@w00fz w00fz added this to the 5.4.14 milestone Jun 28, 2017
@w00fz w00fz closed this as completed in e0661cb Jun 28, 2017
@N8Solutions
Copy link
Author

@w00fz You're awesome Djamil! Thank you for taking care of this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants