Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Context lost briefly during hot reload #119

Closed
natew opened this issue Apr 14, 2015 · 2 comments
Closed

Context lost briefly during hot reload #119

natew opened this issue Apr 14, 2015 · 2 comments

Comments

@natew
Copy link
Contributor

natew commented Apr 14, 2015

I've noticed this and someone else opened this ticket.

In Reapp I've been using the context patch with 0.13 to enable 0.14-like parent context. So perhaps it's just a bit early. But I notice that during the hot reload I get errors where my context objects are undefined. I can find the patch for you, it's in the parent context react thread.

@gaearon
Copy link
Owner

gaearon commented Apr 14, 2015

Have you tried with React master? It should use parent context.
We need to know if it's an inherent issue in RHL, or just an issue with that specific patch.

@gaearon
Copy link
Owner

gaearon commented Apr 14, 2015

I'm pretty sure it's facebook/react#3404 (fixed in facebook/react#3494).
This should get into 0.13.2: facebook/react#3629.

Please reopen if you see this problem in React master.

@gaearon gaearon closed this as completed Apr 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants