From 2d4e6b28cbb6adb9a4f468c9765baafb09437b94 Mon Sep 17 00:00:00 2001
From: Gabriel Schulhof <gabrielschulhof@gmail.com>
Date: Fri, 24 May 2024 20:27:38 -0700
Subject: [PATCH] fix

---
 .github/workflows/ci-win.yml                                 | 5 ++++-
 .github/workflows/ci.yml                                     | 2 +-
 .../threadsafe_function/threadsafe_function_existing_tsfn.cc | 2 +-
 .../typed_threadsafe_function_existing_tsfn.cc               | 2 +-
 4 files changed, 7 insertions(+), 4 deletions(-)

diff --git a/.github/workflows/ci-win.yml b/.github/workflows/ci-win.yml
index 0ef964913..57ccbebc6 100644
--- a/.github/workflows/ci-win.yml
+++ b/.github/workflows/ci-win.yml
@@ -13,7 +13,10 @@ jobs:
     timeout-minutes: 30
     strategy:
       matrix:
-        node-version: [ 18.x, 20.x, 21.x ]
+        node-version:
+          # - 18.x (disabled)
+          - 20.x
+          - 21.x
         architecture: [x64, x86]
         os:
           - windows-2019
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index cd4841ffe..973a20d62 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -17,7 +17,7 @@ jobs:
           - standard
           - experimental
         node-version:
-          - 18.x
+          # - 18.x (disabled because the newest version is unavailable)
           - 20.x
           - 21.x
           - 22.x
diff --git a/test/threadsafe_function/threadsafe_function_existing_tsfn.cc b/test/threadsafe_function/threadsafe_function_existing_tsfn.cc
index ea3241f51..226493703 100644
--- a/test/threadsafe_function/threadsafe_function_existing_tsfn.cc
+++ b/test/threadsafe_function/threadsafe_function_existing_tsfn.cc
@@ -86,7 +86,7 @@ static Value TestCall(const CallbackInfo& info) {
                                       0,
                                       1,
                                       nullptr, /*finalize data*/
-                                      TSFN_FINALIZER(FinalizeCB),
+                                      FinalizeCB,
                                       testContext,
                                       hasData ? CallJSWithData : CallJSNoData,
                                       &testContext->tsfn);
diff --git a/test/typed_threadsafe_function/typed_threadsafe_function_existing_tsfn.cc b/test/typed_threadsafe_function/typed_threadsafe_function_existing_tsfn.cc
index 3c6a4aba5..daa273fcb 100644
--- a/test/typed_threadsafe_function/typed_threadsafe_function_existing_tsfn.cc
+++ b/test/typed_threadsafe_function/typed_threadsafe_function_existing_tsfn.cc
@@ -88,7 +88,7 @@ static Value TestCall(const CallbackInfo& info) {
                                       0,
                                       1,
                                       nullptr, /*finalize data*/
-                                      TSFN_FINALIZER(FinalizeCB),
+                                      FinalizeCB,
                                       testContext,
                                       hasData ? CallJSWithData : CallJSNoData,
                                       &testContext->tsfn);