Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distance comparing algorithm might be wrong #1

Open
BigPanda97 opened this issue Sep 26, 2021 · 0 comments
Open

Distance comparing algorithm might be wrong #1

BigPanda97 opened this issue Sep 26, 2021 · 0 comments

Comments

@BigPanda97
Copy link

BigPanda97 commented Sep 26, 2021

From my understanding of your code, it looks like you are using the mean square error to compare two hashes. But in this document, one of the authors of PhotoDNA states that: “Finally, we compute the similarity of two hashes as the Euclidean distance between two feature vectors, with distances below a specified threshold qualifying as a match.”

So, it looks like the official implementations use the Euclidean distance instead of the mean square error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant