[Bug] Vec<Box<XXX>> is not supported in enum.

[iota9star]

Describe the bug

Dart code is generated well, but rust code is not generated correctly.

Codegen logs with RUST_LOG=debug environment variable

work fine.

To Reproduce

• enum

#[derive(Debug)]
#[frb(dart_metadata = ("freezed",))]
pub enum Test {
    Nothing,
    Array(Vec<Box<Test>>),
}

• api.rs

pub fn test() -> Test {
    Test::Nothing
}

• bridge_generated.rs

impl support::IntoDart for Test {
    fn into_dart(self) -> support::DartAbi {
        match self {
            Self::Nothing => vec![0.into_dart()],
            Self::Array(field0) => vec![1.into_dart(), field0.into_dart()],
        }
        .into_dart()
    }
}

Expected behavior

No response

Generated binding code

No response

OS

No response

Version of flutter_rust_bridge_codegen

No response

Flutter info

No response

Version of clang++

No response

Version of ffigen

No response

Additional context

No response

[welcome]

Hi! Thanks for opening your first issue here! 😄

[fzyzcjy]

Hmm looks like a bug. Feel free to PR to fix it!

guess about the reason: Maybe we forget to run code generator on the type

[iota9star]

@fzyzcjy Can you solve this issue？allo-isolate

[fzyzcjy]

IMHO the bug is unrelated to allo-isolate

[iota9star]

It seems that allo-isolate did not implement into_dart for vec<box> @fzyzcjy I don't know the specific implementation details of frb，Is there a plan to solve it?

[fzyzcjy]

IIRC, many impl IntoDart for WhateverType are auto-generated by frb. You may check bridge_generated.rs etc to see that.

Is there a plan to solve it?

Feel free to PR to fix it! If you get stuck, just ping me :)

[fzyzcjy]

Btw does Vec<Xxx> work, and does Box<Xxx> work?

And, is it possible to workaround it by using Vec<Xxx> without box

[iota9star]

Btw does Vec work, and does Box work?

It works well

[iota9star]

IIRC, many impl IntoDart for WhateverType are auto-generated by frb. You may check bridge_generated.rs etc to see that.

frb doesn't need to generate vec<box>, the following part is correct

impl support::IntoDart for Test {
    fn into_dart(self) -> support::DartAbi {
        match self {
            Self::Nothing => vec![0.into_dart()],
            Self::Array(field0) => vec![1.into_dart(), field0.into_dart()],
        }
        .into_dart()
    }
}

impl support::IntoDartExceptPrimitive for Test {}

[iota9star]

The implementation of vec is in allo-isolate

https://github.com/sunshine-protocol/allo-isolate/blob/0d361ad97b10e7e2c355c495693bb9a82ad0f95c/src/into_dart.rs#L25-L32

https://github.com/sunshine-protocol/allo-isolate/blob/0d361ad97b10e7e2c355c495693bb9a82ad0f95c/src/into_dart.rs#L252-L259

https://github.com/sunshine-protocol/allo-isolate/blob/0d361ad97b10e7e2c355c495693bb9a82ad0f95c/src/dart_array.rs#L17-L34

These codes do not seem to support vec @fzyzcjy

[iota9star]

what fk! vec<box> is missing

[fzyzcjy]

I see, good observation! Then maybe it should be implemented there. For example, I guess adding a few lines such as

impl<T> IntoDart for Box<T>
where
    T: IntoDartExceptPrimitive + Sized,
{
    fn into_dart(self) -> DartCObject {
        (*self).into_dart()
    }
}

should work

[iota9star]

@fzyzcjy Sorry, I didn't use Box correctly. https://rust-lang.github.io/rust-clippy/master/index.html#vec_box
After removing Box, it works well

[github-actions]

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new issue.