Faker Image

[lagunawebdesign]

Could You remove curl() condition in Provider/Image.php - just $success = copy($url, $filepath); works great.
In curl condition there is a problem with unlink() function before fclose().

  /*
        // save file
        if (function_exists('curl_exec')) {
            // use cURL
            $fp = fopen($filepath, 'w');
            $ch = curl_init($url);
            curl_setopt($ch, CURLOPT_FILE, $fp);
            $success = curl_exec($ch) && curl_getinfo($ch, CURLINFO_HTTP_CODE) === 200;

            if ($success) {
                fclose($fp);
            } else {
                unlink($filepath);
            }

            curl_close($ch);
        } elseif (ini_get('allow_url_fopen')) {
            // use remote fopen() via copy()
            $success = copy($url, $filepath);
        } else {
            return new \RuntimeException('The image formatter downloads an image from a remote HTTP server. Therefore, it requires that PHP can request remote hosts, either via cURL or fopen()');
        }
        */
        $success = copy($url, $filepath);`

[fzaninotto]

there is a problem with unlink() function before fclose()

Can you be more specific?

[diegoldev]

In my experience, I was getting this error when I used image() method, working in localhost (using WAMP)
Message: unlink(D:/path/to/facker/img/**e496355.jpg): Permission denied
I've solved it adding this lines before CURLOPT_FILE:
curl_setopt($ch, CURLOPT_SSL_VERIFYHOST, false);
curl_setopt($ch, CURLOPT_SSL_VERIFYPEER, false);
curl_setopt($ch, CURLOPT_FILE, $fp);

[eberkund]

@fzaninotto I can confirm the issue with unlink() and fclose(). I submitted a pull request that resolves it: #1319

[fzaninotto]

Fixed in #1319