This repository has been archived by the owner on May 17, 2019. It is now read-only.
Add event batching on the server #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need docs |
|
Please update the readme |
nadiia
reviewed
Nov 13, 2017
| @@ -114,7 +133,7 @@ Registers a callback to be called when an event of a type is emitted. Note that | |||
| #### `events.emit` | |||
|
|
|||
| ```js | |||
| events.emit(type, payload, ...args) | |||
| events.emit(type, payload) | |||
There was a problem hiding this comment.
seems like the ctx should go as an optional arg here? line 141 also needs to be updated
There was a problem hiding this comment.
I actually don't allow emitting events with ctx as a third argument. It is added by using EventEmitter.of(ctx)
nadiia
approved these changes
Nov 13, 2017
|
!merge |
| for (let index = 0; index < items.length; index++) { | ||
| const {type, payload} = items[index]; | ||
| emitter.emit(type, payload); | ||
| } | ||
| ctx.status = 200; |
There was a problem hiding this comment.
Does it matter that we are now updating status downstream here?
There was a problem hiding this comment.
yea, I think we should set it as early as possible
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7