This repository has been archived by the owner on May 17, 2019. It is now read-only.
Fix bug where mappers were run before batch was flushed #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #26 +/- ##
=========================================
+ Coverage 86.27% 86.4% +0.13%
=========================================
Files 3 3
Lines 102 103 +1
Branches 19 19
=========================================
+ Hits 88 89 +1
Misses 6 6
Partials 8 8
Continue to review full report at Codecov.
|
| if (!this.ctx) { | ||
| payload = super.mapEvent(type, payload, this.ctx); |
There was a problem hiding this comment.
Seems strange that we want to pass in a falsey ctx here?
KevinGrandon
approved these changes
Dec 14, 2017
|
!merge |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #25