Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Ensure global mappers and handlers are called for events emitted from ctx scoped emitter #12

Merged
merged 2 commits into from
Nov 14, 2017
Merged

Ensure global mappers and handlers are called for events emitted from ctx scoped emitter #12

merged 2 commits into from
Nov 14, 2017

Conversation

ganemone
Copy link
Contributor

Fixes #11

@ganemone ganemone self-assigned this Nov 14, 2017
@lhorie
Copy link
Contributor

lhorie commented Nov 14, 2017

This looks like a major breaking change. Should we maybe discuss this change before landing? At a minimum, we need to have some sort of plan regarding the downstreams we own

lhorie
lhorie approved these changes Nov 14, 2017
View reviewed changes
Copy link
Contributor

@lhorie lhorie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's probably room for improvement in terms of cleaning up what goes in the base class vs the server/browser child classes, but for now this seems reasonable

@ganemone
Copy link
Contributor Author

!merge

@old-fusion-bot old-fusion-bot bot merged commit 828887a into fusionjs:master Nov 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lhorie lhorie lhorie approved these changes

Assignees

@ganemone ganemone

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ganemone @lhorie