Skip to content
This repository has been archived by the owner on May 17, 2019. It is now read-only.

Test memory router, ensure Route onRoute is not required #232

Merged
merged 2 commits into from
Feb 20, 2019
Merged

Conversation

lhorie
Copy link
Contributor

@lhorie lhorie commented Feb 20, 2019

Currently, using <MemoryRouter> causes an error that the onRoute context property is required by <Route>.

This PR makes onRoute optional and adds tests to ensure basic usage of MemoryRouter works

@lhorie lhorie added the bugfix label Feb 20, 2019
@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@17aa5bd). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #232   +/-   ##
=========================================
  Coverage          ?   79.35%           
=========================================
  Files             ?       10           
  Lines             ?      218           
  Branches          ?       48           
=========================================
  Hits              ?      173           
  Misses            ?       30           
  Partials          ?       15
Impacted Files Coverage Δ
src/modules/Route.js 76.19% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17aa5bd...5572ba5. Read the comment docs.

2 similar comments
@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@17aa5bd). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #232   +/-   ##
=========================================
  Coverage          ?   79.35%           
=========================================
  Files             ?       10           
  Lines             ?      218           
  Branches          ?       48           
=========================================
  Hits              ?      173           
  Misses            ?       30           
  Partials          ?       15
Impacted Files Coverage Δ
src/modules/Route.js 76.19% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17aa5bd...5572ba5. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@17aa5bd). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #232   +/-   ##
=========================================
  Coverage          ?   79.35%           
=========================================
  Files             ?       10           
  Lines             ?      218           
  Branches          ?       48           
=========================================
  Hits              ?      173           
  Misses            ?       30           
  Partials          ?       15
Impacted Files Coverage Δ
src/modules/Route.js 76.19% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17aa5bd...5572ba5. Read the comment docs.

@lhorie lhorie merged commit 3e9d434 into master Feb 20, 2019
@old-fusion-bot
Copy link

Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1556

@old-fusion-bot old-fusion-bot bot deleted the memoryrouter branch February 20, 2019 16:47
This was referenced Feb 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants