Fix typings of Route #217
Fix typings of Route #217
Conversation
|
|
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
=======================================
Coverage 79.26% 79.26%
=======================================
Files 10 10
Lines 217 217
Branches 47 47
=======================================
Hits 172 172
Misses 30 30
Partials 15 15
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
=======================================
Coverage 79.26% 79.26%
=======================================
Files 10 10
Lines 217 217
Branches 47 47
=======================================
Hits 172 172
Misses 30 30
Partials 15 15
Continue to review full report at Codecov.
|
| @@ -20,26 +20,20 @@ const isEmptyChildren = (children: React.Node) => | |||
| type PropsType = { | |||
| trackingId?: any, | |||
| component?: React.ComponentType<*>, | |||
| render?: (...props: any) => React.Node, | |||
| children?: ((routeProps: {match: MatchType}) => React.Node) | React.Node, | |||
| render?: (routeProps: ContextRouterType) => React.Node, | |||
There was a problem hiding this comment.
Going to look into this, but isn't there additional props that are possible here? Maybe we need to some flow fixtures in the repository.
There was a problem hiding this comment.
this is reflecting https://github.com/fusionjs/fusion-plugin-react-router/pull/217/files#diff-06bff60adf3419abdd857df2169e4f68R49 so it should be good
| @@ -20,26 +20,20 @@ const isEmptyChildren = (children: React.Node) => | |||
| type PropsType = { | |||
| trackingId?: any, | |||
| component?: React.ComponentType<*>, | |||
| render?: (...props: any) => React.Node, | |||
| children?: ((routeProps: {match: MatchType}) => React.Node) | React.Node, | |||
| render?: (routeProps: ContextRouterType) => React.Node, | |||
There was a problem hiding this comment.
this is reflecting https://github.com/fusionjs/fusion-plugin-react-router/pull/217/files#diff-06bff60adf3419abdd857df2169e4f68R49 so it should be good
|
Any reason why this has not been merged yet? |
|
Thanks for the reminder. |
|
!merge |
|
Triggered Fusion.js build verification: https://buildkite.com/uberopensource/fusion-release-verification/builds/1466 |
The full router context is passed to
component,renderandchildren. This should be reflected in the types.