This repository has been archived by the owner on May 17, 2019. It is now read-only.
Add a fusion react-router plugin #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Found TODOs without GitHub issues: |
6a9f42c to
a8677d4
Compare
lhorie
reviewed
Nov 3, 2017
| @@ -1,7 +1,7 @@ | |||
| dist: trusty | |||
| sudo: false | |||
| language: node_js | |||
| node_js: 8.8.0 | |||
| node_js: 8.9.0 | |||
| before_install: | |||
| - curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 1.2.1 | |||
| - export PATH=$HOME/.yarn/bin:$PATH | |||
There was a problem hiding this comment.
Need to add this:
before_script:
- export DISPLAY=':99.0'
- sh -e /etc/init.d/xvfb startotherwise browser tests will hang in CI
There was a problem hiding this comment.
It did hang. Added, thanks!
4aeb999 to
2772006
Compare
lhorie
previously approved these changes
Nov 4, 2017
lhorie
approved these changes
Nov 6, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1