fix: add ./constants exports to separate client from core backend (#398)

Author: sam-goodwin

packages/@eventual/client/src/base-http-client.ts

@@ -1,4 +1,4 @@
-import { commandRpcPath, HttpMethod } from "@eventual/core";
+import { commandRpcPath, HttpMethod } from "@eventual/core/constants";
 import { getRequestHandler } from "./request-handler/factory.js";
 import {
   BeforeRequest,

packages/@eventual/core/.gitignore

@@ -2,4 +2,5 @@
 *.d.ts
 node_modules
 lib
-!internal/*
+!internal/*
+!constants/*

packages/@eventual/core/constants/index.d.ts

@@ -0,0 +1,4 @@
+/**
+ * Alias to the internal module for CJS imports.
+ */
+export * from "../lib/cjs/constants.js";

packages/@eventual/core/package.json

@@ -9,6 +9,10 @@
     "./internal": {
       "import": "./lib/esm/internal/index.js",
       "require": "./lib/cjs/internal/index.js"
+    },
+    "./constants": {
+      "import": "./lib/esm/constants.js",
+      "require": "./lib/cjs/constants.js"
     }
   },
   "main": "./lib/cjs/index.js",

packages/@eventual/core/src/constants.ts

@@ -0,0 +1,2 @@
+export * from "./http/command-rpc-path.js";
+export type * from "./http-method.js";

packages/@eventual/core/src/http/command-rpc-path.ts

@@ -0,0 +1,20 @@
+import type { AnyCommand } from "./command.js";
+
+export function isDefaultNamespaceCommand<
+  C extends Pick<AnyCommand, "name" | "namespace">
+>(command: C): command is C & { namespace: undefined } {
+  return !command.namespace;
+}
+
+/**
+ * Formats the RPC Rest path for a command.
+ *
+ * rpc[/namespace]/name
+ */
+export function commandRpcPath(
+  command: Pick<AnyCommand, "name" | "namespace">
+) {
+  return `rpc${
+    isDefaultNamespaceCommand(command) ? "" : `/${command.namespace}`
+  }${command.name.startsWith("/") ? "" : "/"}${command.name}`;
+}

packages/@eventual/core/src/http/command.ts

@@ -7,25 +7,6 @@ import type { ServiceContext } from "../service.js";
 import type { Middleware } from "./middleware.js";
 import type { ParsePath } from "./path.js";
 
-export function isDefaultNamespaceCommand<
-  C extends Pick<AnyCommand, "name" | "namespace">
->(command: C): command is C & { namespace: undefined } {
-  return !command.namespace;
-}
-
-/**
- * Formats the RPC Rest path for a command.
- *
- * rpc[/namespace]/name
- */
-export function commandRpcPath(
-  command: Pick<AnyCommand, "name" | "namespace">
-) {
-  return `rpc${
-    isDefaultNamespaceCommand(command) ? "" : `/${command.namespace}`
-  }${command.name.startsWith("/") ? "" : "/"}${command.name}`;
-}
-
 export interface CommandContext {
   service: ServiceContext;
 }

packages/@eventual/core/src/http/index.ts

@@ -1,5 +1,6 @@
 export * from "./api.js";
 export * from "./command.js";
+export * from "./command-rpc-path.js";
 export * from "./error.js";
 export * from "./middleware.js";
 export * from "./request-response.js";

packages/@eventual/core/src/internal/global.ts

@@ -74,7 +74,7 @@ export function getEventualResource<Kind extends ResourceKind>(
 export function getEventualResources<Kind extends ResourceKind>(
   resourceKind: Kind
 ): Map<string, ResourceOfKind<Kind>> {
-  return globalThis._eventual.resources[resourceKind] ?? new Map();
+  return (globalThis._eventual.resources[resourceKind] ??= new Map());
 }
 
 /**

packages/@eventual/core/src/internal/open-api-spec.ts

@@ -1,5 +1,5 @@
 import type openapi from "openapi3-ts";
-import { commandRpcPath } from "../http/command.js";
+import { commandRpcPath } from "../http/command-rpc-path.js";
 import type { CommandSpec } from "./service-spec.js";
 
 export interface OpenAPISpecOptions {