Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autocorrelation doesn't return the same result for pl.LazyFrame and pl.DataFrame #65

Closed
MathieuCayssol opened this issue Oct 8, 2023 · 4 comments
Closed

autocorrelation doesn't return the same result for pl.LazyFrame and pl.DataFrame #65

MathieuCayssol opened this issue Oct 8, 2023 · 4 comments
Assignees
@abstractqqq

Comments

@MathieuCayssol
Copy link
Collaborator

The correct result is for the Eager mode.

Capture d’écran 2023-10-08 à 11 47 02

Capture d’écran 2023-10-08 à 11 47 54
@abstractqqq
Copy link
Collaborator

This is likely a Polars Bug

@abstractqqq
Copy link
Collaborator

@topher-lo @MathieuCayssol As of 0.19.8, the underlying Polars issue is fixed. We can try again using slice... Polars updates very fast..... I will implement the change in Mathieu's PR... Let's consider upgrading Polars version?

See here.
pola-rs/polars#11594

@MathieuCayssol
Copy link
Collaborator Author

Thanks a lot @abstractqqq!!! I just updated my PR with your previous implementation and the tests

@topher-lo
Copy link
Contributor

Resolved by #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abstractqqq abstractqqq

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@topher-lo @MathieuCayssol @abstractqqq