Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inquiry of used_license result #544

Open
bjk7119 opened this issue Jun 20, 2022 · 1 comment
Open

Inquiry of used_license result #544

bjk7119 opened this issue Jun 20, 2022 · 1 comment
Labels
bug Something isn't working question Further information is requested

Comments

@bjk7119
Copy link

bjk7119 commented Jun 20, 2022

Hello.
I would like to inquire about no license file because the 'file_report.spdxfile.licenses_in_file' value varies depending on the file extension.

the value of 'file_report.spdxfile.licenses_in_file' :

  • .py file or .yaml file with no license : empty
  • .xlsx file with no license : '-'

The values of 'file_report.spdxfile.licenses_in_file' are diffrent depends on the file extension
I'd like to ask if it's normal result to have different file extensions.

the following caputre is the log that I inserted to check result in 'report.py':
image

image

@nicorikken nicorikken added the bug Something isn't working label Jul 6, 2022
@nicorikken
Copy link
Member

Thanks for the in-depth bug report. I tried reproducing it but I wasn't capable of doing so. I added the printing line in used_licenses() in report.py and created two empty spreadsheet files using LibreOffice, one in .ods and one in .xslx format. As that didn't result in the ['-'] output but just in [] I tried creating a spreadshit with some SPDX identifiers in it, but that didn't change the output.

Can you perhaps share a spreadsheet file that is causing the issue?

Looking through the code I would expect that extract_spdx_info() in _util.py is the function responsible for producing the '-' output.

I notice that you are actually working on the FOSSLight wrapper for REUSE. Perhaps there are other parts of the code that have changed and might alter the behavior? The -p flag is something on the whishlist for REUSE as well #512 so rather than going our own ways I hope we can collaborate to avoid duplicating efforts.

Could it be that fosslight_reuse is actually trying to parse the spreadsheet as an OSS-report? https://github.com/fosslight/fosslight_reuse/blob/main/src/fosslight_oss_pkg/_parsing_excel.py I only know about FOSSLight from a presentation I attended, so I might be missing some context.

@mxmehl mxmehl added the question Further information is requested label Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants