Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shall datetime with format=default support optional timezone offsets? #830

Closed
peterdesmet opened this issue Jun 20, 2023 · 2 comments
Closed
Assignees

Comments

@peterdesmet
Copy link
Member

peterdesmet commented Jun 20, 2023

Frictionless Framework will correctly parse the following datetimes with a format = default (datapackage.json.zip):

2013-11-23T08:30:00      # No timezone
2013-11-23T08:30:00Z     # UTC time
2013-11-23T06:30:00-0200 # Timezone offset

This is great! But according to the specs only UTC times should be supported (excluding offsets or no timezone):

default: An ISO8601 format string e.g. YYYY-MM-DDThh:mm:ssZ in UTC time

Is the more broad support intentional? Should the specs be updated to drop the in UTC time?

Originating issue: tdwg/camtrap-dp#333

@roll roll added the fix label Jun 26, 2023
@roll roll self-assigned this Jun 26, 2023
@roll roll transferred this issue from frictionlessdata/frictionless-py Jun 27, 2023
@roll roll moved this from Current to Inbox in Open Knowledge Jun 27, 2023
@roll roll changed the title datetime with format=default supports timezone offsets Shall datetime with format=default support optional timezone offsets? Jun 27, 2023
@roll roll added Table Schema and removed fix labels Jun 27, 2023
@roll roll added this to the v2 milestone Jun 27, 2023
@roll
Copy link
Member

roll commented Jun 27, 2023

I think we def need to handle it in v2

@roll roll removed the status in Open Knowledge Jul 3, 2023
@roll roll removed their assignment Jul 3, 2023
@roll roll self-assigned this Jan 25, 2024
@roll
Copy link
Member

roll commented Jan 26, 2024

MERGED into #487

@roll roll closed this as completed Jan 26, 2024
@roll roll added the duplicate label Jan 26, 2024
@roll roll removed this from the v2 milestone Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

2 participants