Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support groupChar for integer type #498

Closed
rufuspollock opened this issue Jul 30, 2017 · 3 comments · Fixed by frictionlessdata/datapackage-v2-draft#6
Closed

Support groupChar for integer type #498

rufuspollock opened this issue Jul 30, 2017 · 3 comments · Fixed by frictionlessdata/datapackage-v2-draft#6
Assignees
@roll
Labels
Table Schema
Milestone
v2.0

Comments

@rufuspollock
Copy link
Contributor

No description provided.

@rufuspollock rufuspollock added this to the v1.0 milestone Jul 30, 2017
@pwalsh
Copy link
Member

pwalsh commented Aug 1, 2017

yes. doing a PR now.

@pwalsh
Copy link
Member

pwalsh commented Aug 1, 2017

Actually, no. I'm moving to v1.1. With the current behaviour, for example, data that represents a monetary value will always be cast as a number. With such a change, we'd have to start making further decisions about when something is a number or an integer.

@pwalsh pwalsh modified the milestones: v1.1, v1.0 Aug 1, 2017
@pwalsh pwalsh assigned rufuspollock and unassigned rufuspollock Aug 1, 2017
@Stephen-Gates
Copy link
Contributor

Are you just suggesting groupChar here as bareNumber is supported and decimalChar doesn't make sense for integer

@roll roll modified the milestones: v1.1, v2 Apr 14, 2023
@roll roll changed the title Should integer have (most) of the same formatting options as number? Support groupChar for integer type Jan 3, 2024
@roll roll mentioned this issue Jan 5, 2024
Merged
@roll roll added the proposal label Jan 5, 2024
@roll roll self-assigned this Jan 5, 2024
@nichtich nichtich mentioned this issue Jan 7, 2024
Closed
@nichtich nichtich mentioned this issue Feb 7, 2024
Closed
@roll roll mentioned this issue Feb 19, 2024
Closed
@roll roll modified the milestones: v2.0-draft, v2.0 Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@roll roll

Labels
Table Schema
Projects
Open Knowledge
Status: Done
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

Support groupChar for integer field type frictionlessdata/datapackage-v2-draft
4 participants
@rufuspollock @roll @pwalsh @Stephen-Gates