Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super Mario Bros. and Super Mario Mushroom World table crash with color rom palette .VNI and PAC files #405

Closed
Mrtr32 opened this issue Aug 18, 2023 · 16 comments

Comments

@Mrtr32
Copy link

Mrtr32 commented Aug 18, 2023

The Super Mario Bros. and Super Mario Mushroom World table crash with colors .VNI or PAC file in the color rom folder
Removing the color files and all is working as expected without colors.

I'm not sure this issue is related to the DMDEXT v2.2 Final.

All other tables with color roms work great!

@Mrtr32 Mrtr32 changed the title Super Mario Bros. and Super Mario Mushroom World table crash with colors Super Mario Bros. and Super Mario Mushroom World table crash with colors roms files Aug 18, 2023
@Mrtr32 Mrtr32 changed the title Super Mario Bros. and Super Mario Mushroom World table crash with colors roms files Super Mario Bros. and Super Mario Mushroom World table crash with color rom palette files VNI and PAC Aug 18, 2023
@passionforpins
Copy link

verified. totally crashes vpx 10.7.4 x86 and x64. However it does work with freezys dll's dated 8/10/2023 (2.2.0-plugins r112)

@Mrtr32
Copy link
Author

Mrtr32 commented Aug 18, 2023

totally crashes VPX 10.8.0 x86 also.

@Mrtr32 Mrtr32 changed the title Super Mario Bros. and Super Mario Mushroom World table crash with color rom palette files VNI and PAC Super Mario Bros. and Super Mario Mushroom World table crash with color rom palette .VNI and PAC files Aug 18, 2023
@Mrtr32
Copy link
Author

Mrtr32 commented Aug 19, 2023

After more testing finaly isolated the exact setting that causing tables to crashes
The default settings vni.scalermode = doubler dont show anything on DMD and cause the table crashes

The workaround for .vni and pal files only is to set vni.scalermode = scale2x and all is working as expected

Only the smb3.pac file crashes the table

Thanks!

@workerb0y
Copy link

After more testing finaly isolated the exact setting that causing tables to crashes The default settings vni.scalermode = doubler dont show anything on DMD and cause the table crashes

The workaround is to set vni.scalermode = scale2x and all is working as expected

Thanks!

You mean at the dmddevice.ini? I have a simple "scalermode" line but it's set to scale2x and the table still crashed.

@Mrtr32
Copy link
Author

Mrtr32 commented Aug 19, 2023

@workerb0y

Yes I mean dmdevice.ini

You need to overwrite all the files with the ones in the v2.2.0 build

You seems to have an old dmddevice.ini if vni.scalermode is not present.

@workerb0y
Copy link

@workerb0y

Yes I mean dmdevice.ini

You need to overwrite all the files with the ones in the v2.2.0 build

You seems to have an old dmddevice.ini if vni.scalermode is not present.

Yes, I just filled that gap. But unfortunately, the table still crashes, no matter how I set it up.

@Mrtr32
Copy link
Author

Mrtr32 commented Aug 19, 2023

make sure you have vni.scalermode = scale2x in the dmddevice.ini

@workerb0y
Copy link

Yes, it is set to scale2x. Still the same error, SMB crashes after a few seconds and there is nothing on the dmd screen.

@Mrtr32
Copy link
Author

Mrtr32 commented Aug 19, 2023

Are you using the .vni and .pal files in the altcolor folder?

Only the smb3.pac file crashes the table.

@workerb0y
Copy link

I have both and use the pac.
But meantime somehow it solved, I copied the dll-s here and there and probably your suggestion was helped. :)
I testted some tables and everything looks fine now.

@Mrtr32
Copy link
Author

Mrtr32 commented Aug 19, 2023

What is the dlls you are using?

Currently the smb3.pac crashes and dont work on my setup.

@workerb0y
Copy link

Sorry, I seem to have messed things up a bit. I used an earlier dll from the beginning of March (possibly Lucky), replaced the new one with it, and tried the colorings one by one. So if I only use the latest freezy, the pac doesn't work properly.

@Mrtr32
Copy link
Author

Mrtr32 commented Aug 19, 2023

I never installed the Lucky dlls on my cab so it will be very cool to have the PAC working like .VNI/PAL and cRZ.

Thanks!

@freezy freezy closed this as completed in 25615f1 Aug 20, 2023
@freezy
Copy link
Owner

freezy commented Aug 20, 2023

Can you guys try this and confirm if the problem is fixed?

@workerb0y
Copy link

Can you guys try this and confirm if the problem is fixed?

Yes, thank you so much! It looks like everything (all 3 colorizations) works perfect with this version on x64. I use only x64 so I didn't tried the x86. For me, it's perfect now! Thanks again!

@Mrtr32
Copy link
Author

Mrtr32 commented Aug 20, 2023

Wow this is the first time I see the PAC working on my cab!

Everything is working great with the 2.2.1 test build x86

Thank you very much freezy for all your excellent work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants