From 28bef423080b843caa1b8c639426a347e8ea6bde Mon Sep 17 00:00:00 2001
From: Maharshi Patel <maharshi.patel988@gmail.com>
Date: Fri, 24 May 2024 13:10:20 +0530
Subject: [PATCH 1/2] fix: change heightType check to string

In recent change we added 3 types of height fixed, auto, auto (min-height) so we converted property to string from boolean.
check in dynamic text was for boolean so changed it to string comparison
---
 .../page/print_designer/jinja/macros/dynamictext.html       | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/print_designer/print_designer/page/print_designer/jinja/macros/dynamictext.html b/print_designer/print_designer/page/print_designer/jinja/macros/dynamictext.html
index 6a1d450..1002381 100644
--- a/print_designer/print_designer/page/print_designer/jinja/macros/dynamictext.html
+++ b/print_designer/print_designer/page/print_designer/jinja/macros/dynamictext.html
@@ -1,9 +1,9 @@
 {% from 'print_designer/page/print_designer/jinja/macros/spantag.html' import span_tag with context %}
 
-{% macro dynamictext(element, send_to_jinja, is_parent_dynamic_height) -%}
-<div style="position:{%- if is_parent_dynamic_height != 'fixed' -%}relative{% else %}absolute{%- endif -%}; {%- if is_parent_dynamic_height == 'fixed'  -%}top: {%- else -%}margin-top: {%- endif -%}{{ element.startY }}px; left:{{ element.startX }}px;{% if element.isFixedSize %}width:{{ element.width }}px; {%- if is_parent_dynamic_height == 'fixed' -%}height:{{ element.height }}px; {%- endif -%} {% else %} width:fit-content; height:fit-content; white-space:nowrap; max-width: {{ (settings.page.width - settings.page.marginLeft - settings.page.marginRight - element.startX) + 2 }}px;{%endif%}" class="
+{% macro dynamictext(element, send_to_jinja, heightType) -%}
+<div style="position:{%- if heightType != 'fixed' -%}relative{% else %}absolute{%- endif -%}; {%- if heightType == 'fixed'  -%}top: {%- else -%}margin-top: {%- endif -%}{{ element.startY }}px; left:{{ element.startX }}px;{% if element.isFixedSize %}width:{{ element.width }}px; {%- if heightType == 'fixed' -%}height:{{ element.height }}px; {%- endif -%} {% else %} width:fit-content; height:fit-content; white-space:nowrap; max-width: {{ (settings.page.width - settings.page.marginLeft - settings.page.marginRight - element.startX) + 2 }}px;{%endif%}" class="
     {{ element.classes | join(' ') }}">
-        <div style="{% if element.isFixedSize %}width:{{ element.width }}px; {%- if not is_parent_dynamic_height -%}height:{{ element.height }}px; {%- endif -%}{% else %}width:fit-content; height:fit-content; white-space:nowrap; max-width: {{ (settings.page.width - settings.page.marginLeft - settings.page.marginRight - element.startX) + 2 }}px;{%endif%} {{convert_css(element.style)}}"
+        <div style="{% if element.isFixedSize %}width:{{ element.width }}px; {%- if heightType == 'fixed'  -%}height:{{ element.height }}px; {%- endif -%}{% else %}width:fit-content; height:fit-content; white-space:nowrap; max-width: {{ (settings.page.width - settings.page.marginLeft - settings.page.marginRight - element.startX) + 2 }}px;{%endif%} {{convert_css(element.style)}}"
             class="dynamicText {{ element.classes | join(' ') }}">
             {% for field in element.dynamicContent %}
             <!-- third Arg is row which is not sent outside table -->

From 39f7ea6b0790c3a123016757f7c09618726812bc Mon Sep 17 00:00:00 2001
From: Maharshi Patel <maharshi.patel988@gmail.com>
Date: Fri, 24 May 2024 13:18:29 +0530
Subject: [PATCH 2/2] chore: rename is_parent_dynamic_height to heightType

---
 .../page/print_designer/jinja/macros/rectangle.html    |  6 +++---
 .../print_designer/jinja/macros/render_element.html    | 10 +++++-----
 .../page/print_designer/jinja/macros/statictext.html   |  6 +++---
 .../page/print_designer/jinja/macros/table.html        |  4 ++--
 4 files changed, 13 insertions(+), 13 deletions(-)

diff --git a/print_designer/print_designer/page/print_designer/jinja/macros/rectangle.html b/print_designer/print_designer/page/print_designer/jinja/macros/rectangle.html
index ee5e0ac..e795ad7 100644
--- a/print_designer/print_designer/page/print_designer/jinja/macros/rectangle.html
+++ b/print_designer/print_designer/page/print_designer/jinja/macros/rectangle.html
@@ -1,13 +1,13 @@
-{% macro rectangle(element, render_element, send_to_jinja, is_parent_dynamic_height) -%}
+{% macro rectangle(element, render_element, send_to_jinja, heightType) -%}
     {%- set heightType = element.get("heightType") -%}
     {%- if settings.get("schema_version") == "1.1.0" -%}
         {%- set heightType = "auto" if element.get("isDynamicHeight", False) else "fixed" -%}
     {%- endif -%}
-    <div id="{{ element.id }}" style="position:{%- if is_parent_dynamic_height != 'fixed' -%}relative{% else %}absolute{%- endif -%}; {%- if is_parent_dynamic_height == 'fixed' -%}top: {%- else -%}margin-top: {%- endif -%}{{ element.startY }}px; left:{{ element.startX }}px; width:{{ element.width }}px; {%- if heightType != 'auto' -%} {%- if heightType == 'auto-min-height' -%}min-{%- endif -%}height:{{ element.height }}px; {%- endif -%} {{convert_css(element.style)}}"
+    <div id="{{ element.id }}" style="position:{%- if heightType != 'fixed' -%}relative{% else %}absolute{%- endif -%}; {%- if heightType == 'fixed' -%}top: {%- else -%}margin-top: {%- endif -%}{{ element.startY }}px; left:{{ element.startX }}px; width:{{ element.width }}px; {%- if heightType != 'auto' -%} {%- if heightType == 'auto-min-height' -%}min-{%- endif -%}height:{{ element.height }}px; {%- endif -%} {{convert_css(element.style)}}"
     class="rectangle {{ element.classes | join(' ') }}">
         {% if element.childrens %}
             {% for object in element.childrens %}
-               {{ render_element(object, send_to_jinja, is_parent_dynamic_height) }}
+               {{ render_element(object, send_to_jinja, heightType) }}
             {% endfor %}
         {% endif %}
     </div>
diff --git a/print_designer/print_designer/page/print_designer/jinja/macros/render_element.html b/print_designer/print_designer/page/print_designer/jinja/macros/render_element.html
index d2820e2..f9892a8 100644
--- a/print_designer/print_designer/page/print_designer/jinja/macros/render_element.html
+++ b/print_designer/print_designer/page/print_designer/jinja/macros/render_element.html
@@ -7,18 +7,18 @@
 {% from 'print_designer/page/print_designer/jinja/macros/table.html' import table with context %}
 
 
-{% macro render_element(element, send_to_jinja, is_parent_dynamic_height = 'fixed') -%}
+{% macro render_element(element, send_to_jinja, heightType = 'fixed') -%}
     {% if element.type == "rectangle" %}
-        {{ rectangle(element, render_element, send_to_jinja, is_parent_dynamic_height) }}
+        {{ rectangle(element, render_element, send_to_jinja, heightType) }}
     {% elif element.type == "image" %}
         {{image(element)}}
     {% elif element.type == "table" %}
-        {{table(element, send_to_jinja, is_parent_dynamic_height)}}
+        {{table(element, send_to_jinja, heightType)}}
     {% elif element.type == "text" %}
         {% if element.isDynamic %}
-            {{dynamictext(element, send_to_jinja, is_parent_dynamic_height)}}
+            {{dynamictext(element, send_to_jinja, heightType)}}
         {% else%}
-            {{statictext(element, send_to_jinja, is_parent_dynamic_height)}}
+            {{statictext(element, send_to_jinja, heightType)}}
         {% endif %}
     {% elif element.type == "barcode" %}
         {{barcode(element, send_to_jinja)}}
diff --git a/print_designer/print_designer/page/print_designer/jinja/macros/statictext.html b/print_designer/print_designer/page/print_designer/jinja/macros/statictext.html
index 9a34b8b..82aafd4 100644
--- a/print_designer/print_designer/page/print_designer/jinja/macros/statictext.html
+++ b/print_designer/print_designer/page/print_designer/jinja/macros/statictext.html
@@ -1,8 +1,8 @@
 <!-- third Arg in render_user_text is row which is not sent outside table -->
-{% macro statictext(element, send_to_jinja, is_parent_dynamic_height) -%}
-<div style="position:{%- if is_parent_dynamic_height != 'fixed' -%}relative{% else %}absolute{%- endif -%}; {%- if is_parent_dynamic_height == 'fixed'  -%}top: {%- else -%}margin-top: {%- endif -%}{{ element.startY }}px; left:{{ element.startX }}px;{% if element.isFixedSize %}width:{{ element.width }}px;{%- if is_parent_dynamic_height == 'fixed' -%}height:{{ element.height }}px; {%- endif -%}{% else %}width:fit-content; height:fit-content; max-width: {{ (settings.page.width - settings.page.marginLeft - settings.page.marginRight - element.startX) + 2 }}px; white-space:nowrap; {%endif%}" class="
+{% macro statictext(element, send_to_jinja, heightType) -%}
+<div style="position:{%- if heightType != 'fixed' -%}relative{% else %}absolute{%- endif -%}; {%- if heightType == 'fixed'  -%}top: {%- else -%}margin-top: {%- endif -%}{{ element.startY }}px; left:{{ element.startX }}px;{% if element.isFixedSize %}width:{{ element.width }}px;{%- if heightType == 'fixed' -%}height:{{ element.height }}px; {%- endif -%}{% else %}width:fit-content; height:fit-content; max-width: {{ (settings.page.width - settings.page.marginLeft - settings.page.marginRight - element.startX) + 2 }}px; white-space:nowrap; {%endif%}" class="
     {{ element.classes | join(' ') }}">
-    <p style="{% if element.isFixedSize %}width:{{ element.width }}px; {%- if is_parent_dynamic_height == 'fixed' -%}height:{{ element.height }}px; {%- endif -%}{% else %}width:fit-content; height:fit-content; max-width: {{ (settings.page.width - settings.page.marginLeft - settings.page.marginRight - element.startX ) + 2 }}px; white-space:nowrap;{%endif%} {{convert_css(element.style)}}"
+    <p style="{% if element.isFixedSize %}width:{{ element.width }}px; {%- if heightType == 'fixed' -%}height:{{ element.height }}px; {%- endif -%}{% else %}width:fit-content; height:fit-content; max-width: {{ (settings.page.width - settings.page.marginLeft - settings.page.marginRight - element.startX ) + 2 }}px; white-space:nowrap;{%endif%} {{convert_css(element.style)}}"
         class="staticText {{ element.classes | join(' ') }}">
         {% if element.parseJinja %}
            {{ render_user_text(element.content, doc, {}, send_to_jinja).get("message", "") }}
diff --git a/print_designer/print_designer/page/print_designer/jinja/macros/table.html b/print_designer/print_designer/page/print_designer/jinja/macros/table.html
index 9c6ce09..2550739 100644
--- a/print_designer/print_designer/page/print_designer/jinja/macros/table.html
+++ b/print_designer/print_designer/page/print_designer/jinja/macros/table.html
@@ -1,9 +1,9 @@
-{% macro table(element, send_to_jinja, is_parent_dynamic_height) -%}
+{% macro table(element, send_to_jinja, heightType) -%}
     {%- set heightType = element.get("heightType") -%}
     {%- if settings.get("schema_version") == "1.1.0" -%}
         {%- set heightType = "auto" if element.get("isDynamicHeight", False) else "fixed" -%}
     {%- endif -%}
-    <table style="position:{%- if is_parent_dynamic_height != 'fixed' -%}relative{% else %}absolute{%- endif -%}; {%- if is_parent_dynamic_height == 'fixed' -%}top: {%- else -%}margin-top: {%- endif -%}{{ element.startY }}px; left:{{ element.startX }}px; width:{{ element.width }}px;{%- if is_parent_dynamic_height != 'fixed' and heightType != 'auto' -%}{%- if heightType == 'auto-min-height' -%}min-{%- endif -%}height:{{ element.height }}px;{%- endif -%} max-width:{{ element.width }}px;" class="table-container printTable {{ element.classes | join(' ') }}">
+    <table style="position:{%- if heightType != 'fixed' -%}relative{% else %}absolute{%- endif -%}; {%- if heightType == 'fixed' -%}top: {%- else -%}margin-top: {%- endif -%}{{ element.startY }}px; left:{{ element.startX }}px; width:{{ element.width }}px;{%- if heightType != 'fixed' and heightType != 'auto' -%}{%- if heightType == 'auto-min-height' -%}min-{%- endif -%}height:{{ element.height }}px;{%- endif -%} max-width:{{ element.width }}px;" class="table-container printTable {{ element.classes | join(' ') }}">
             <thead>
             {% if element.columns %}
                 <tr>