This repository has been archived by the owner on Dec 6, 2021. It is now read-only.
docs: Docs for Custom Webform Context hook #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 3, 2021
surajshetty3416
suggested changes
Sep 6, 2021
gavindsouza
suggested changes
Oct 22, 2021
| @@ -433,6 +433,23 @@ The above configuration will render `/not_found` when a 404 is occurred. It is | |||
| upto you to implement the template `www/not_found.html` and controller | |||
| `www/not_found.py`. | |||
|
|
|||
| ## Custom Web Form Context | |||
There was a problem hiding this comment.
Suggested change
| ## Custom Web Form Context | |
| ## Web Form Context |
| @@ -433,6 +433,23 @@ The above configuration will render `/not_found` when a 404 is occurred. It is | |||
| upto you to implement the template `www/not_found.html` and controller | |||
| `www/not_found.py`. | |||
|
|
|||
| ## Custom Web Form Context | |||
|
|
|||
| When a Web Form is created using non custom doctype, we can get the context from doctype's module but for Web Form using custom doctype you cannot get the context since custom doctype don't have modules, you can use this hook to create a context for Custom Web Form. | |||
There was a problem hiding this comment.
Suggested change
| When a Web Form is created using non custom doctype, we can get the context from doctype's module but for Web Form using custom doctype you cannot get the context since custom doctype don't have modules, you can use this hook to create a context for Custom Web Form. | |
| When a Web Form is created for a standard doctype, we can get the context from doctype's module. Although for a Web Form for a custom doctype you cannot get the context since custom doctype don't have modules, you can use this hook to create a context for Custom Web Form. |
I tried re-wording this.
The sentence is too complex...Maybe break it down into 2-3 simpler sentences.
Use standard instead of "non custom", if it fits.
Also, wording for "doctype's module" is ambiguous. Even I'm not sure what you're talking about 😅
|
Hi @shariquerik , We moved to a new simpler contribution pipeline. Please move your changes (with requested changes) in this PR to the new site. You can now directly contribute to frappeframework.com. For new contribution guidelines, refer to frappeframework.com/contribute. Thanks for the contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs for getting context for custom webform using hooks.