feat: Add STARTTLS authentification method for IMAP protocol #17683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #17683 +/- ##
===========================================
+ Coverage 62.62% 62.84% +0.21%
===========================================
Files 755 755
Lines 68065 67826 -239
Branches 5976 5976
===========================================
- Hits 42628 42626 -2
+ Misses 21975 21806 -169
+ Partials 3462 3394 -68
Flags with carried forward coverage won't be shown. Click here to find out more. |
feat: add STARTTLS connexion option for IMAP server email
407b14a to
e60c101
Compare
bc376c2 to
a3a9f11
Compare
phot0n
reviewed
Aug 14, 2022
There was a problem hiding this comment.
Hey, thanks for this. I've currently done a very shallow review but would need to dig a bit deeper for doing a more comprehensive review.
If you want I can provide you credential to test a STARTTLS infrastructure, just ping me
Would like to take you up on the offer. If you're on telegram, you can reach out to me at: @phot0nx
Thanks.
…nd updated translations
546c647 to
d2795a5
Compare
phot0n
reviewed
Aug 19, 2022
mergify bot
pushed a commit
that referenced
this pull request
Aug 19, 2022
Co-authored-by: phot0n <ritwikpuri5678@gmail.com> (cherry picked from commit 11a17d3)
phot0n
added a commit
that referenced
this pull request
Aug 19, 2022
…-17683 feat: Add STARTTLS authentification method for IMAP protocol (backport #17683)
FHenry
added a commit
to FHenry/frappe
that referenced
this pull request
Aug 19, 2022
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 19, 2022
# [14.4.0](v14.3.0...v14.4.0) (2022-08-19) ### Bug Fixes * convert pk from db to str. ([#17876](#17876)) ([c56aed8](c56aed8)) * pop pwd from form dict, disable auth logging (backport [#17872](#17872)) ([#17874](#17874)) ([da0c12a](da0c12a)) ### Features * STARTTLS authentication for IMAP ([#17683](#17683)) ([0838584](0838584)) ### Performance Improvements * ~65% faster `create_custom_fields` ([#17875](#17875)) ([c27e6bf](c27e6bf))
phot0n
pushed a commit
that referenced
this pull request
Aug 22, 2022
frappe-pr-bot
pushed a commit
that referenced
this pull request
Aug 23, 2022
# [13.39.0](v13.38.1...v13.39.0) (2022-08-23) ### Bug Fixes * notifications always showing up as "unread" ([#17890](#17890)) ([f648c9b](f648c9b)) * pop pwd from form dict, disable auth logging (backport [#17872](#17872)) ([#17873](#17873)) ([8051b76](8051b76)) * Turkey number format corrected ([#17886](#17886)) ([b0a808b](b0a808b)) * Unexpected triggers in forms on shifting focus (backport [#17283](#17283)) ([#17902](#17902)) ([c930c26](c930c26)) ### Features * STARTTLS authentication for IMAP (backport [#17683](#17683)) ([#17881](#17881)) ([c28f39c](c28f39c))
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Add STARTTLS authentification method for IMAP protocol
Some IMAP server use STARTTLS protocol, this feature is actually missing in frappe and do not allow to use incoming email feature to be managed
If you want I can provide you credantial to test a STARTTLS infrastructure, just ping me