-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Validity dates in Tax Withholding Rates (backport #27258) #46124
Conversation
(cherry picked from commit 5e10e10) # Conflicts: # erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py # erpnext/accounts/doctype/tax_withholding_category/test_tax_withholding_category.py # erpnext/accounts/doctype/tax_withholding_rate/tax_withholding_rate.json # erpnext/patches.txt # erpnext/patches/v13_0/update_dates_in_tax_withholding_category.py
(cherry picked from commit d06221a) # Conflicts: # erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py
(cherry picked from commit b6d0b17) # Conflicts: # erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py # erpnext/patches/v13_0/update_dates_in_tax_withholding_category.py
(cherry picked from commit d5a736d)
(cherry picked from commit 092d41e) # Conflicts: # erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py
(cherry picked from commit 51d9572) # Conflicts: # erpnext/accounts/doctype/fiscal_year/fiscal_year_dashboard.py # erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py
(cherry picked from commit c33bbd4) # Conflicts: # erpnext/accounts/doctype/purchase_invoice/test_purchase_invoice.py
(cherry picked from commit e7e2ce1) # Conflicts: # erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py # erpnext/patches/v13_0/update_dates_in_tax_withholding_category.py
Cherry-pick of 5e10e10 has failed:
Cherry-pick of d06221a has failed:
Cherry-pick of b6d0b17 has failed:
Cherry-pick of 092d41e has failed:
Cherry-pick of 51d9572 has failed:
Cherry-pick of c33bbd4 has failed:
Cherry-pick of e7e2ce1 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Replaced fiscal year in tax withholding rates with from and to date and patched existing records by Fiscal Year Start and End Dates
The reason for replacing this will from and to date is some categories come into effect from the mid of the fiscal year and hence only the invoices made during that period should be considered for checking threshold and not the entire fiscal year
no-docs
This is an automatic backport of pull request #27258 done by Mergify.