fix: add missing disbursement account in update_old_loans patch

[anandbaburajan]

The patch was failing with:

  File "/home/frappe/frappe-bench/apps/erpnext/erpnext/patches/v13_0/update_old_loans.py", line 131, in execute
    loan_type_doc.submit()
      updated_loan_types = []
      loans_to_close = ['ACC-LOAN-2019-00001', 'ELN0004']
      loans_list = [{'parent': 'ACC-LOAN-2019-00001'}, {'parent': 'ELN0004'}]
      loans = [{'name': 'ACC-LOAN-2019-00001', 'loan_type': 'Advances', 'company': 'Greentek India Limited', 'status': 'Disbursed', 'mode_of_payment': 'Online', 'applicant_type': 'Employee', 'applicant': 'EMP/0142', 'loan_account': 'Emp Advances - GIPL', 'payment_account': 'Kotak Mahindra Bank - 05522000005884 - GIPL', 'interest_income_account': 'Interest Income - GIPL'}, {'name': 'ELN0004', 'loan_type': 'Advances', 'company': 'Greentek India Limited', 'status': 'Fully Disbursed', 'mode_of_payment': 'Cash', 'applicant_type': 'Employee', 'applicant': 'EMP/0141', 'loan_account': 'Imprest Account - GIPL', 'payment_account': 'Cash Office - GIPL', 'interest_income_account': 'Interest Income - GIPL'}]
      loan = {'name': 'ACC-LOAN-2019-00001', 'loan_type': 'Advances', 'company': 'Greentek India Limited', 'status': 'Disbursed', 'mode_of_payment': 'Online', 'applicant_type': 'Employee', 'applicant': 'EMP/0142', 'loan_account': 'Emp Advances - GIPL', 'payment_account': 'Kotak Mahindra Bank - 05522000005884 - GIPL', 'interest_income_account': 'Interest Income - GIPL'}
      loan_type_company = None
      loan_type = 'Advances'
      group_income_account = 'Indirect Income - GIPL'
      penalty_account = 'Penalty Account - GIPL'
      loan_type_doc = <LoanType: Advances docstatus=1>
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 1010, in submit
    return self._submit()
      self = <LoanType: Advances docstatus=1>
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 989, in _submit
    return self.save()
      self = <LoanType: Advances docstatus=1>
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 309, in save
    return self._save(*args, **kwargs)
      self = <LoanType: Advances docstatus=1>
      args = ()
      kwargs = {}
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 346, in _save
    self._validate()
      self = <LoanType: Advances docstatus=1>
      ignore_permissions = None
      ignore_version = None
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 533, in _validate
    self._validate_mandatory()
      self = <LoanType: Advances docstatus=1>
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 868, in _validate_mandatory
    raise frappe.MandatoryError(
      self = <LoanType: Advances docstatus=1>
      missing = [('disbursement_account', 'Error: Value missing for Loan Type: Disbursement Account')]
      fieldname = 'disbursement_account'
      msg = 'Error: Value missing for Loan Type: Disbursement Account'
frappe.exceptions.MandatoryError: [Loan Type, Advances]: disbursement_account

Related: #32403

[anandbaburajan]

@mergify backport version-14

[mergify]

backport version-14

✅ Backports have been created

• #37894 fix: add missing disbursement account in update_old_loans patch (backport #37889) has been created for branch version-14

[frappe-pr-bot]

🎉 This PR is included in version 14.47.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀