Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: German Translation of Shift #37375

Closed
wants to merge 3 commits into from
Closed

fix: German Translation of Shift #37375

wants to merge 3 commits into from

Conversation

lfirewall1243
Copy link

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Screenshots/GIFs

@lfirewall1243
German Translation for "Shift"
05ba714 
Editing the german translation of "Shift". At the moment its translated to something like "Switch Type" not shift in the working hours context
@lfirewall1243
Update de.csv
38c07c8
@barredterra barredterra added the squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. label Oct 5, 2023
barredterra
barredterra requested changes Oct 5, 2023
View reviewed changes
@lfirewall1243 @barredterra
Update de.csv
665f8ec 
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
@barredterra
Copy link
Collaborator

barredterra commented Oct 5, 2023 •
edited
Loading

Ah, the Shift doctype is no longer a part of ERPNext. Sorry for the confusion. For v14+, please contribute translations to https://github.com/frappe/hrms . For v13, create a pull request against ERPNext version-13-hotfix.

I created two cleanup PRs that move existing translations between ERPNext and HRMS:

frappe/hrms#942, #37376

@barredterra barredterra closed this Oct 5, 2023
@lfirewall1243
Copy link
Author

Good to know for the future.
Thanks :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@barredterra barredterra barredterra requested changes

Assignees
No one assigned
Labels
squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lfirewall1243 @barredterra