Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added validation for the batch on stock reco #37174

Conversation

rohitwaghchaure
Copy link
Collaborator

Issue

  1. Create a batch Item ABC with purchase receipt for 100 qty with rate as 1000 and batch as ABC-001
  2. Create a another batch Item PQR
  3. Create Stock reconciliation for the Item PQR and select the batch as ABC-001
  4. System will allow to make stock reconciliation which is an incorrect.

After Fix

Added validation which won't allow users to make stock reconciliation for the item with batches of different items.

@rohitwaghchaure rohitwaghchaure force-pushed the fixed-added-validation-for-batch branch from 43d10e8 to 8ba8669 Compare October 6, 2023 06:34
@rohitwaghchaure rohitwaghchaure merged commit 4c337a6 into frappe:version-14-hotfix Oct 6, 2023
frappe-pr-bot pushed a commit that referenced this pull request Oct 12, 2023
# [14.44.0](v14.43.1...v14.44.0) (2023-10-12)

### Bug Fixes

* added validation for the batch on stock reco ([#37174](#37174)) ([4c337a6](4c337a6))
* ageing summary in AR ([15d2024](15d2024))
* allocate amt for payment term invoices ([b22ac13](b22ac13))
* call validate before setting repost flag ([bec3e8e](bec3e8e))
* do not run bg job for single doc ([4123e7b](4123e7b))
* **Employee:** enable `no_copy` for `relieving_date` (backport [#37344](#37344)) ([#37358](#37358)) ([2b38b78](2b38b78))
* exception on exporting errored rows ([e58b3b1](e58b3b1))
* fetch company details for Lead based quotation ([c1d40a6](c1d40a6))
* fetch dependent task subject and project (backport [#37401](#37401)) ([#37421](#37421)) ([0aad942](0aad942))
* ignore cancelled gle in voucher-wise balance report ([#36417](#36417)) ([ee1255a](ee1255a))
* incorrect status of the returned purchase receipt ([#37300](#37300)) ([63f4573](63f4573))
* linting issues ([6c8a65e](6c8a65e))
* negative valuation rate in PR return ([#37424](#37424)) ([26ad688](26ad688))
* payment request rounding in multi-currency and on status update ([eed5863](eed5863))
* production plan reserved qty incorrect calculation (backport [#37400](#37400)) ([#37458](#37458)) ([573b159](573b159))
* split inv allocated amt on server side ([06b0477](06b0477))
* typo in doctype name and qb ([606c99e](606c99e))
* **ux:** allow MR to Stop until fully received (backport [#37452](#37452)) ([#37456](#37456)) ([fb0b426](fb0b426))
* validation for si ([3dc68e3](3dc68e3))

### Features

* add repost btn in invoice ([cde848d](cde848d))
* allow on submit fields ([f5245f6](f5245f6))
* allow repost for pi ([2d13dda](2d13dda))
* composite WIP asset ([#37352](#37352)) ([0ecd7d2](0ecd7d2))
* disable currency exchange api. ([#33593](#33593)) ([1ca0516](1ca0516))
* filter on voucher no ([cb35218](cb35218))
* introduce unreconcile doctype ([ae8355c](ae8355c))
* UI for unreconcile ([9531a45](9531a45))
* unreconcile support for journal entry ([cd2d335](cd2d335))
* validate negative stock for inventory dimension ([#37373](#37373)) ([1480aca](1480aca))
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.44.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants