fix: payment request rounding in multi-currency and on status update

[blaggacao]

Follow up on #36844

Context

1. Make Sales Order:
   • in other than company currency
   • with a rounding adjustment amount
2. Create and fulfill that foreign currency payment request
3. Then the total amount in the payment entry's child table references will not be the rounded total but the grand total, despite the above Ref Doc having had a rounding adjustment amount

Proposed Solution

abandonded due to issue note in this comment

Rather rely on set_grand_total_and_outstanding_amount invoked by get_payment_entry which fetches
the right amounts when no party_amount is passed:

def set_grand_total_and_outstanding_amount(party_amount, dt, party_account_currency, doc):
	grand_total = outstanding_amount = 0
	if party_amount:
		grand_total = outstanding_amount = party_amount
	elif dt in ("Sales Invoice", "Purchase Invoice"):
		if party_account_currency == doc.company_currency:
			grand_total = doc.base_rounded_total or doc.base_grand_total
		else:
			grand_total = doc.rounded_total or doc.grand_total
		outstanding_amount = doc.outstanding_amount
	elif dt == "Dunning":
		grand_total = doc.grand_total
		outstanding_amount = doc.grand_total
	else:
		if party_account_currency == doc.company_currency:
			grand_total = flt(doc.get("base_rounded_total") or doc.get("base_grand_total"))
		else:
			grand_total = flt(doc.get("rounded_total") or doc.get("grand_total"))
		outstanding_amount = doc.get("outstanding_amount") or (grand_total - flt(doc.advance_paid))
	return grand_total, outstanding_amount

Similarily, rely on set_party_account and set_party_account_currency, respectively, instead of the removed portions of code.

• Do the right thing and prefer base_rounded_total if exists according to other examples of fetching a refdoc total values throughout the code.

[codecov]

Codecov Report

Merging #37123 (6e1ad4c) into develop (5e21e7c) will increase coverage by 0.06%.
Report is 10 commits behind head on develop.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #37123      +/-   ##
===========================================
+ Coverage    66.56%   66.62%   +0.06%     
===========================================
  Files          793      793              
  Lines        62468    62501      +33     
===========================================
+ Hits         41582    41644      +62     
+ Misses       20886    20857      -29     

Files Changed	Coverage
...ccounts/doctype/payment_request/payment_request.py	100.00%

[barredterra]

Shouldn't this apply to the other branch of the condition as well?

(party_amount = self.get("rounded_total") or self.get("grand_total"))

Probably not the issue you're trying to solve, but good for consistency and in accordance with other parts of the code.

[ruthra-kumar]

@barredterra 'Payment Request' doctype doesn't have rounded_total.

[ruthra-kumar]

@blaggacao Tried some scenarios and change works fine. If you can add a test case for this, we can merge it.