-
Notifications
You must be signed in to change notification settings - Fork 7.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: customer group and territory not mandatory #37050
fix: customer group and territory not mandatory #37050
Conversation
Nice improvement and certainly the right choice to not require customer group and territory on every single site (may still be overridden locally)! But sorry to say, this does not really fix #36849‘s underlying, and broader issue which is the fact that select filters are individual JS code, so don‘t propagate to the Quick Entry form. |
@bosue |
…lop-ritvik-customer-ter-not-rqd
…lop-ritvik-customer-ter-not-rqd
Codecov Report
@@ Coverage Diff @@
## develop #37050 +/- ##
========================================
Coverage 66.70% 66.71%
========================================
Files 794 794
Lines 62541 62495 -46
========================================
- Hits 41721 41691 -30
+ Misses 20820 20804 -16 |
…lop-ritvik-customer-ter-not-rqd
@RitvikSardana Do the same for supplier as well |
…com/RitvikSardana/erpnext into develop-ritvik-customer-ter-not-rqd
…lop-ritvik-customer-ter-not-rqd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can only comment, but looks good, quick and easy. 👍
…lop-ritvik-customer-ter-not-rqd
…lop-ritvik-customer-ter-not-rqd
While in the full-size DocType form, DocType links are correctly filtered to exclude group items:
… in the quick entry form they’re not, so group items may be selected:
So making customer group and territory not mandatory.