Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: customer group and territory not mandatory #37050

Conversation

RitvikSardana
Copy link
Member

@RitvikSardana RitvikSardana commented Sep 12, 2023

While in the full-size DocType form, DocType links are correctly filtered to exclude group items:

image

… in the quick entry form they’re not, so group items may be selected:

image.

So making customer group and territory not mandatory.

@bosue
Copy link
Contributor

bosue commented Sep 12, 2023

Nice improvement and certainly the right choice to not require customer group and territory on every single site (may still be overridden locally)!

But sorry to say, this does not really fix #36849‘s underlying, and broader issue which is the fact that select filters are individual JS code, so don‘t propagate to the Quick Entry form.

@RitvikSardana
Copy link
Member Author

@bosue
you can actually control the quick entry form
you can check it here:
https://github.com/frappe/erpnext/blob/develop/erpnext/public/js/utils/contact_address_quick_entry.js

@RitvikSardana RitvikSardana self-assigned this Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #37050 (b51531d) into develop (d9eb44e) will increase coverage by 0.00%.
Report is 42 commits behind head on develop.
The diff coverage is n/a.

❗ Current head b51531d differs from pull request most recent head 62b4e3c. Consider uploading reports for the commit 62b4e3c to get more accurate results

@@           Coverage Diff            @@
##           develop   #37050   +/-   ##
========================================
  Coverage    66.70%   66.71%           
========================================
  Files          794      794           
  Lines        62541    62495   -46     
========================================
- Hits         41721    41691   -30     
+ Misses       20820    20804   -16     

see 13 files with indirect coverage changes

@deepeshgarg007
Copy link
Member

@RitvikSardana Do the same for supplier as well

Copy link
Contributor

@bosue bosue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can only comment, but looks good, quick and easy. 👍

bosue

This comment was marked as off-topic.

@deepeshgarg007 deepeshgarg007 merged commit 2c899dd into frappe:develop Oct 9, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter group items for selection in Quick Entry form
3 participants