Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate duplicate date in holiday list #37022

Merged
merged 4 commits into from
Sep 19, 2023
Merged

feat: validate duplicate date in holiday list #37022

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e20c167
feat: validate duplicate date in table
niyazrazak Sep 11, 2023
45c7311
chore: cleanup
deepeshgarg007 Sep 13, 2023
40ea35f
chore: linting issues
deepeshgarg007 Sep 19, 2023
b92e266
chore: linting issues
deepeshgarg007 Sep 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions erpnext/setup/doctype/holiday_list/holiday_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ class HolidayList(Document):
def validate(self):
self.validate_days()
self.total_holidays = len(self.holidays)
self.validate_dupliacte_date()

@frappe.whitelist()
def get_weekly_off_dates(self):
Expand Down Expand Up @@ -124,6 +125,14 @@ def get_weekly_off_date_list(self, start_date, end_date):
def clear_table(self):
self.set("holidays", [])

def validate_dupliacte_date(self):
unique_dates = []
for row in self.holidays:
if row.holiday_date in unique_dates:
frappe.throw(_("Holiday Date {0} added multiple times").format(frappe.bold(row.holiday_date)))

unique_dates.append(row.holiday_date)


@frappe.whitelist()
def get_events(start, end, filters=None):
Expand Down