Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: validate duplicate date in holiday list #37022

Merged
merged 4 commits into from
Sep 19, 2023

Conversation

niyazrazak
Copy link
Contributor

@niyazrazak niyazrazak commented Sep 11, 2023

Currently in ERPNext user can add same date multiple times in holiday list.

This PR will restrict user for adding duplicate date in table

no-docs

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Sep 11, 2023
@niyazrazak niyazrazak marked this pull request as ready for review September 11, 2023 08:24
@niyazrazak niyazrazak changed the title feat: validate duplicate date in table feat: validate duplicate date in holiday list Sep 11, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #37022 (b92e266) into develop (ce549ce) will increase coverage by 0.67%.
Report is 107 commits behind head on develop.
The diff coverage is 85.71%.

@@             Coverage Diff             @@
##           develop   #37022      +/-   ##
===========================================
+ Coverage    65.93%   66.61%   +0.67%     
===========================================
  Files          796      793       -3     
  Lines        62753    62524     -229     
===========================================
+ Hits         41379    41653     +274     
+ Misses       21374    20871     -503     
Files Changed Coverage
erpnext/setup/doctype/holiday_list/holiday_list.py 85.71%

@deepeshgarg007 deepeshgarg007 merged commit 141ba25 into frappe:develop Sep 19, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants