Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tax category field in tax withholding details report #36974

Conversation

GursheenK
Copy link
Member

Changes

  • Removed tax_withholding_category from common fields since Sales Invoice does not have the field.
  • Added a test to Tax Withholding Details report to catch such common bugs.

no-docs

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #36974 (175870c) into develop (d2f03c8) will increase coverage by 0.19%.
Report is 4 commits behind head on develop.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop   #36974      +/-   ##
===========================================
+ Coverage    65.55%   65.74%   +0.19%     
===========================================
  Files          796      796              
  Lines        62719    62730      +11     
===========================================
+ Hits         41115    41244     +129     
+ Misses       21604    21486     -118     
Files Changed Coverage
...tax_withholding_details/tax_withholding_details.py 100.00%

@deepeshgarg007 deepeshgarg007 merged commit c849a01 into frappe:develop Sep 10, 2023
@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label Sep 10, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants