Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: calcuate received/paid amount on exchange rate change in Payment Entry #36888

Conversation

ruthra-kumar
Copy link
Member

@ruthra-kumar ruthra-kumar commented Aug 31, 2023

When source/target exchange rate is changed in Payment Entry, use it to calculate received/paid amount. This is so no difference amount is calculated by system, unless user specifically changes the received/paid amount.

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 31, 2023
@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #36888 (64d8353) into develop (5e38109) will increase coverage by 0.00%.
Report is 7 commits behind head on develop.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop   #36888   +/-   ##
========================================
  Coverage    65.42%   65.42%           
========================================
  Files          794      794           
  Lines        62194    62194           
========================================
+ Hits         40689    40693    +4     
+ Misses       21505    21501    -4     
Files Changed Coverage
...xt/accounts/doctype/payment_entry/payment_entry.py 100.00%

@ruthra-kumar ruthra-kumar force-pushed the gain_loss_refactor_issue_01_patch_failed branch from ea2b597 to 64d8353 Compare August 31, 2023 12:29
@ruthra-kumar ruthra-kumar merged commit 0d26f67 into frappe:develop Aug 31, 2023
@ruthra-kumar
Copy link
Member Author

@Mergifyio backport version-14

@mergify
Copy link
Contributor

mergify bot commented Aug 31, 2023

backport version-14

✅ Backports have been created

ruthra-kumar added a commit that referenced this pull request Aug 31, 2023
fix: calcuate received/paid amount on exchange rate change in Payment Entry (backport #36888)
@ruthra-kumar ruthra-kumar added the backport version-14-hotfix backport to version 14 label Aug 31, 2023
ruthra-kumar added a commit that referenced this pull request Sep 1, 2023
…-36888

fix: calcuate received/paid amount on exchange rate change in Payment Entry (backport #36888)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant