Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore_user_permissions set to 1 for parent field of tree doctypes #36869

Conversation

RitvikSardana
Copy link
Member

@RitvikSardana RitvikSardana commented Aug 29, 2023

ignore_user_permission flag was unchecked in Department,Location and Quality Procedure.
So ticked it for all these 3.

Linked PR: #22235

@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #36869 (de433d8) into develop (6d9cebf) will increase coverage by 0.22%.
Report is 109 commits behind head on develop.
The diff coverage is 74.07%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36869      +/-   ##
===========================================
+ Coverage    65.20%   65.42%   +0.22%     
===========================================
  Files          792      794       +2     
  Lines        61861    62181     +320     
===========================================
+ Hits         40334    40681     +347     
+ Misses       21527    21500      -27     
Files Changed Coverage Δ
...ype/request_for_quotation/request_for_quotation.py 54.70% <0.00%> (ø)
.../report/procurement_tracker/procurement_tracker.py 17.18% <0.00%> (ø)
erpnext/controllers/stock_controller.py 82.52% <ø> (ø)
...stock/doctype/material_request/material_request.py 74.68% <ø> (ø)
...e/asset_value_adjustment/asset_value_adjustment.py 80.88% <62.50%> (ø)
erpnext/controllers/accounts_controller.py 86.11% <67.85%> (+<0.01%) ⬆️
...e/payment_reconciliation/payment_reconciliation.py 93.68% <75.00%> (ø)
erpnext/accounts/utils.py 73.99% <77.77%> (ø)
...preciation_schedule/asset_depreciation_schedule.py 89.42% <83.87%> (ø)
erpnext/selling/doctype/customer/customer.py 75.72% <85.71%> (-0.10%) ⬇️
... and 8 more

... and 23 files with indirect coverage changes

@RitvikSardana RitvikSardana changed the title ignore_user_permissions for parent field of tree doctypes fix: ignore_user_permissions set to 1 for parent field of tree doctypes Aug 30, 2023
@surajshetty3416 surajshetty3416 merged commit f032476 into frappe:develop Aug 30, 2023
@RitvikSardana RitvikSardana self-assigned this Sep 4, 2023
@RitvikSardana RitvikSardana added the backport version-14-hotfix backport to version 14 label Sep 4, 2023
ankush added a commit that referenced this pull request Sep 4, 2023
…-36869

fix: ignore_user_permissions set to 1 for parent field of tree doctypes (backport #36869)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants