Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Setup flake8 to stop turning trailing commas into tuples #36850

Merged
merged 1 commit into from
Aug 29, 2023

Conversation

cogk
Copy link
Contributor

@cogk cogk commented Aug 28, 2023

There was a couple of unwanted single element tuples (abc,) in the codebase because of automated re-formatting.

I tried finding more by searching for the string ,) but I only found these.

I added flake8-tuple to prevent this kind of automatically introduced bug from happening again

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #36850 (a150119) into develop (9d330a1) will increase coverage by 0.00%.
Report is 15 commits behind head on develop.
The diff coverage is 69.23%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #36850   +/-   ##
========================================
  Coverage    65.42%   65.42%           
========================================
  Files          794      794           
  Lines        62172    62172           
========================================
+ Hits         40673    40674    +1     
+ Misses       21499    21498    -1     
Files Changed Coverage Δ
..._integrations/connectors/woocommerce_connection.py 0.00% <0.00%> (ø)
...xt/accounts/doctype/payment_entry/payment_entry.py 83.50% <100.00%> (ø)
erpnext/controllers/accounts_controller.py 86.11% <100.00%> (ø)
erpnext/controllers/selling_controller.py 80.88% <100.00%> (ø)
erpnext/e_commerce/shopping_cart/cart.py 52.39% <100.00%> (ø)
...cturing/doctype/production_plan/production_plan.py 80.26% <100.00%> (ø)

... and 1 file with indirect coverage changes

@deepeshgarg007 deepeshgarg007 merged commit 5c4df3e into frappe:develop Aug 29, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants