Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Accounts Payable Currency bug #36758

Merged

Conversation

RitvikSardana
Copy link
Member

@RitvikSardana RitvikSardana commented Aug 22, 2023

Accounts payable was showing incorrect value when filtered by party

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #36758 (9349bc7) into develop (e93b927) will decrease coverage by 0.01%.
Report is 6 commits behind head on develop.
The diff coverage is 71.42%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36758      +/-   ##
===========================================
- Coverage    65.19%   65.18%   -0.01%     
===========================================
  Files          792      792              
  Lines        61814    61804      -10     
===========================================
- Hits         40299    40288      -11     
- Misses       21515    21516       +1     
Files Changed Coverage Δ
...ype/request_for_quotation/request_for_quotation.py 54.70% <0.00%> (-1.00%) ⬇️
erpnext/controllers/buying_controller.py 84.66% <ø> (ø)
...e/asset_value_adjustment/asset_value_adjustment.py 80.88% <62.50%> (-6.49%) ⬇️
...preciation_schedule/asset_depreciation_schedule.py 89.32% <84.00%> (-0.52%) ⬇️
.../report/accounts_receivable/accounts_receivable.py 77.37% <100.00%> (ø)
..._receivable_summary/accounts_receivable_summary.py 92.15% <100.00%> (ø)
erpnext/assets/doctype/asset/asset.py 80.92% <100.00%> (+1.34%) ⬆️

@RitvikSardana RitvikSardana self-assigned this Aug 22, 2023
@deepeshgarg007 deepeshgarg007 merged commit 53926b0 into frappe:develop Aug 22, 2023
@deepeshgarg007 deepeshgarg007 added the backport version-14-hotfix backport to version 14 label Aug 22, 2023
deepeshgarg007 added a commit that referenced this pull request Aug 22, 2023
…-36758

fix: Accounts Payable Currency bug (#36758)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants