Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: enabled indexing for voucher no in SABB #36688

Conversation

rohitwaghchaure
Copy link
Collaborator

Enabled search indexing for Voucher No and Voucher Detail No fields in Serial and Batch Bundle for better performance

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #36688 (9d453fa) into develop (cd28d15) will increase coverage by 0.10%.
Report is 101 commits behind head on develop.
The diff coverage is 93.33%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36688      +/-   ##
===========================================
+ Coverage    64.72%   64.82%   +0.10%     
===========================================
  Files          791      792       +1     
  Lines        61633    61803     +170     
===========================================
+ Hits         39891    40064     +173     
+ Misses       21742    21739       -3     
Files Changed Coverage Δ
erpnext/assets/doctype/asset/asset.py 79.57% <0.00%> (ø)
erpnext/controllers/print_settings.py 57.89% <ø> (ø)
erpnext/hooks.py 100.00% <ø> (ø)
...eport/item_shortage_report/item_shortage_report.py 93.54% <ø> (ø)
erpnext/assets/doctype/asset/depreciation.py 84.09% <92.85%> (ø)
...xt/accounts/doctype/journal_entry/journal_entry.py 69.41% <100.00%> (ø)
...e/payment_reconciliation/payment_reconciliation.py 88.21% <100.00%> (ø)
...preciation_schedule/asset_depreciation_schedule.py 89.84% <100.00%> (ø)
...e/asset_value_adjustment/asset_value_adjustment.py 87.36% <100.00%> (ø)

... and 21 files with indirect coverage changes

@rohitwaghchaure rohitwaghchaure merged commit 3f6ff8e into frappe:develop Aug 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant