Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Transaction currency columns in GL report #36684

Merged

Conversation

deepeshgarg007
Copy link
Member

@deepeshgarg007 deepeshgarg007 commented Aug 17, 2023

Screenshot 2023-08-17 at 11 32 17 AM

Provision to add debit and credit columns in transaction currency

no-docs

@github-actions github-actions bot added accounts needs-tests This PR needs automated unit-tests. labels Aug 17, 2023
@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #36684 (35be3ac) into develop (924911e) will decrease coverage by 0.01%.
Report is 17 commits behind head on develop.
The diff coverage is 81.81%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #36684      +/-   ##
===========================================
- Coverage    64.82%   64.82%   -0.01%     
===========================================
  Files          792      792              
  Lines        61798    61814      +16     
===========================================
+ Hits         40063    40073      +10     
- Misses       21735    21741       +6     
Files Changed Coverage Δ
...t/accounts/report/general_ledger/general_ledger.py 67.43% <66.66%> (-0.02%) ⬇️
erpnext/controllers/accounts_controller.py 86.15% <100.00%> (+0.04%) ⬆️

... and 5 files with indirect coverage changes

@deepeshgarg007 deepeshgarg007 merged commit c70abaa into frappe:develop Aug 17, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accounts needs-tests This PR needs automated unit-tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant