Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tax withholding post LDC limit consumed (backport #36611) #36643

Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 14, 2023

This is an automatic backport of pull request #36611 done by Mergify.
Cherry-pick of 985ff97 has failed:

On branch mergify/bp/version-14-hotfix/pr-36611
Your branch is up to date with 'origin/version-14-hotfix'.

You are currently cherry-picking commit 985ff9781b.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   erpnext/accounts/doctype/tax_withholding_category/tax_withholding_category.py

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   erpnext/accounts/doctype/tax_withholding_category/test_tax_withholding_category.py

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* fix: Tax withholding post LDC limit consumed

* fix: LDC condition check

(cherry picked from commit 985ff97)

# Conflicts:
#	erpnext/accounts/doctype/tax_withholding_category/test_tax_withholding_category.py
@deepeshgarg007 deepeshgarg007 merged commit 1deebe8 into version-14-hotfix Aug 16, 2023
@mergify mergify bot deleted the mergify/bp/version-14-hotfix/pr-36611 branch August 16, 2023 02:40
@frappe-pr-bot
Copy link
Collaborator

🎉 This PR is included in version 14.35.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants