Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disallow mulitple SO with same Purchase Order No if not enabled in Settings #36590

Merged
merged 2 commits into from
Aug 11, 2023
Merged

fix: disallow mulitple SO with same Purchase Order No if not enabled in Settings #36590

merged 2 commits into from
Aug 11, 2023

Conversation

ruthra-kumar
Copy link
Member

When Allow Multiple Sales Orders Against a Customer's Purchase Order is disabled in Selling settings, honour it.

Screenshot 2023-08-11 at 10 03 16 AM

@github-actions github-actions bot added the needs-tests This PR needs automated unit-tests. label Aug 11, 2023
@ruthra-kumar ruthra-kumar force-pushed the disallow_multiple_so_if_blocked_in_settings branch from eda0206 to 6c3f08d Compare August 11, 2023 06:34
@ruthra-kumar ruthra-kumar force-pushed the disallow_multiple_so_if_blocked_in_settings branch 2 times, most recently from d55f555 to aed3d80 Compare August 11, 2023 10:50
@ruthra-kumar ruthra-kumar force-pushed the disallow_multiple_so_if_blocked_in_settings branch from aed3d80 to 64614cd Compare August 11, 2023 12:14
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #36590 (64614cd) into develop (e64b004) will increase coverage by 0.07%.
Report is 50 commits behind head on develop.
The diff coverage is 40.00%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #36590      +/-   ##
===========================================
+ Coverage    64.70%   64.77%   +0.07%     
===========================================
  Files          791      792       +1     
  Lines        61572    61781     +209     
===========================================
+ Hits         39838    40020     +182     
- Misses       21734    21761      +27
Files Changed Coverage Δ
erpnext/selling/doctype/sales_order/sales_order.py 77.00% <25.00%> (-0.38%) ⬇️
...xt/accounts/doctype/sales_invoice/sales_invoice.py 83.88% <100.00%> (ø)

... and 16 files with indirect coverage changes

@ruthra-kumar ruthra-kumar merged commit 713880a into frappe:develop Aug 11, 2023
@ruthra-kumar ruthra-kumar added the backport version-14-hotfix backport to version 14 label Aug 13, 2023
@mergify mergify bot mentioned this pull request Aug 13, 2023
Merged
ruthra-kumar added a commit that referenced this pull request Aug 13, 2023
@ruthra-kumar
Merge pull request #36620 from frappe/mergify/bp/version-14-hotfix/pr…
df632d7 
…-36590

fix: disallow mulitple SO with same Purchase Order No if not enabled in Settings (backport #36590)
@mergify mergify bot mentioned this pull request Aug 16, 2023
Merged
ruthra-kumar added a commit that referenced this pull request Aug 16, 2023
@ruthra-kumar
Merge pull request #36671 from frappe/mergify/bp/version-13-hotfix/pr…
066cf0e 
…-36590

fix: disallow mulitple SO with same Purchase Order No if not enabled in Settings (backport #36590)
@ruthra-kumar
Copy link
Member Author

@Mergifyio backport version-13

@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2023 •
edited
Loading

backport version-13

✅ Backports have been created

@mergify mergify bot mentioned this pull request Aug 17, 2023
Merged
ruthra-kumar added a commit that referenced this pull request Aug 17, 2023
@ruthra-kumar
Merge pull request #36680 from frappe/mergify/bp/version-13/pr-36590
966c296 
fix: disallow mulitple SO with same Purchase Order No if not enabled in Settings (backport #36590)
@ankush ankush mentioned this pull request Oct 20, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

@s-aga-r s-aga-r Awaiting requested review from s-aga-r

Assignees
No one assigned
Labels
backport version-13-hotfix backport version-14-hotfix backport to version 14 needs-tests This PR needs automated unit-tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ruthra-kumar